public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Frederik Harwath <frederik@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/omp/gcc-12] openmp: Fix loop transformation tests
Date: Tue, 25 Apr 2023 13:48:56 +0000 (GMT)	[thread overview]
Message-ID: <20230425134856.624C43858D32@sourceware.org> (raw)

https://gcc.gnu.org/g:fe884508f6b92ae84ba888b1fc431327ed0b2388

commit fe884508f6b92ae84ba888b1fc431327ed0b2388
Author: Frederik Harwath <frederik@codesourcery.com>
Date:   Tue Apr 25 15:32:56 2023 +0200

    openmp: Fix loop transformation tests
    
    libgomp/ChangeLog:
    
            * testsuite/libgomp.fortran/loop-transforms/tile-2.f90: Add reduction clause.
            * testsuite/libgomp.fortran/loop-transforms/unroll-1.f90: Initialize var.
            * testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90: Add reduction
            and initialization.

Diff:
---
 libgomp/ChangeLog.omp                                              | 7 +++++++
 libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90       | 2 +-
 libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90     | 2 ++
 .../testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90    | 3 ++-
 4 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index 32bc3b0c82c..9cca6a97666 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,3 +1,10 @@
+2023-04-25  Frederik Harwath  <frederik@codesourcery.com>
+
+	* testsuite/libgomp.fortran/loop-transforms/tile-2.f90: Add reduction clause.
+	* testsuite/libgomp.fortran/loop-transforms/unroll-1.f90: Initialize var.
+	* testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90: Add reduction
+	and initialization.
+
 2023-04-20  Andrew Stubbs  <ams@codesourcery.com>
 
 	* basic-allocator.c (basic_alloc_free): Use BASIC_ALLOC_YIELD.
diff --git a/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90 b/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90
index 6aedbf4724f..a7cb5e7635d 100644
--- a/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90
+++ b/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90
@@ -69,7 +69,7 @@ module test_functions
     integer :: i,j
 
     sum = 0
-    !$omp parallel do collapse(2)
+    !$omp parallel do collapse(2) reduction(+:sum)
     !$omp tile sizes(6,10)
     do i = 1,10,3
        do j = 1,10,3
diff --git a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90 b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90
index f07aab898fa..b91ea275577 100644
--- a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90
@@ -8,6 +8,7 @@ module test_functions
 
     integer :: i,j
 
+    sum = 0
     !$omp do
     do i = 1,10,3
        !$omp unroll full
@@ -22,6 +23,7 @@ module test_functions
 
     integer :: i,j
 
+    sum = 0
     !$omp parallel do reduction(+:sum)
     !$omp unroll partial(2)
     do i = 1,10,3
diff --git a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90 b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90
index 5fb64ddd6fd..7a43458f0dd 100644
--- a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90
@@ -9,7 +9,8 @@ module test_functions
 
     integer :: i,j
 
-    !$omp simd
+    sum = 0
+    !$omp simd reduction(+:sum)
     do i = 1,10,3
        !$omp unroll full
        do j = 1,10,3

                 reply	other threads:[~2023-04-25 13:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425134856.624C43858D32@sourceware.org \
    --to=frederik@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).