From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id 9CF673858413; Thu, 27 Apr 2023 15:01:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CF673858413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1682607669; bh=yibwfLxHhBva1JmWFbnN05upSTD51i39f8J7/5M5iKM=; h=From:To:Subject:Date:From; b=YCTwW+RwLSgwGafIfu3MiNCPYOA0tPIhEuesP1uJECDsFtVsHHRd+uOLeK43O/Kpc MaEepzNb4Ts5NdQPIj1OWEwdhvOgSsl5A2WrXJdEZjXybI6Rvwtwzs5Hl/HHgss2ba IjdxXYGXYVgL3a19SfeLi1suR0teVz/+NE47SpiI= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-306] MIN/MAX should be treated similar as comparisons for trapping X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: ba9975a259656d099b67ad2b9c69bf970be2b210 X-Git-Newrev: 5fecfed8788eb114508e36e465147f2bb856fa33 Message-Id: <20230427150109.9CF673858413@sourceware.org> Date: Thu, 27 Apr 2023 15:01:09 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5fecfed8788eb114508e36e465147f2bb856fa33 commit r14-306-g5fecfed8788eb114508e36e465147f2bb856fa33 Author: Andrew Pinski Date: Sat Apr 1 22:50:27 2023 +0000 MIN/MAX should be treated similar as comparisons for trapping While looking into moving optimizations from minmax_replacement in phiopt to match.pd, I Noticed that min/max were considered trapping even if -ffinite-math-only was being used. This changes those expressions to be similar as comparisons so that they are not considered trapping if -ffinite-math-only is on. OK? Bootstrapped and tested with no regressions on x86_64-linux-gnu. gcc/ChangeLog: * rtlanal.cc (may_trap_p_1): Treat SMIN/SMAX similar as COMPARISON. * tree-eh.cc (operation_could_trap_helper_p): Treate MIN_EXPR/MAX_EXPR similar as other comparisons. Diff: --- gcc/rtlanal.cc | 3 +++ gcc/tree-eh.cc | 3 +++ 2 files changed, 6 insertions(+) diff --git a/gcc/rtlanal.cc b/gcc/rtlanal.cc index c96a88cebf1..b7948ecfad1 100644 --- a/gcc/rtlanal.cc +++ b/gcc/rtlanal.cc @@ -3204,6 +3204,9 @@ may_trap_p_1 (const_rtx x, unsigned flags) case LT: case LTGT: case COMPARE: + /* Treat min/max similar as comparisons. */ + case SMIN: + case SMAX: /* Some floating point comparisons may trap. */ if (!flag_trapping_math) break; diff --git a/gcc/tree-eh.cc b/gcc/tree-eh.cc index 425323ff7d6..934209d205f 100644 --- a/gcc/tree-eh.cc +++ b/gcc/tree-eh.cc @@ -2490,6 +2490,9 @@ operation_could_trap_helper_p (enum tree_code op, case GT_EXPR: case GE_EXPR: case LTGT_EXPR: + /* MIN/MAX similar as LT/LE/GT/GE. */ + case MIN_EXPR: + case MAX_EXPR: /* Some floating point comparisons may trap. */ return honor_nans;