public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Stubbs <ams@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-310] amdgcn: Fix addsub bug
Date: Thu, 27 Apr 2023 16:33:40 +0000 (GMT) [thread overview]
Message-ID: <20230427163340.98A303858D33@sourceware.org> (raw)
https://gcc.gnu.org/g:b17c57b06d90f2ca12ea0395046c4ea7d439065f
commit r14-310-gb17c57b06d90f2ca12ea0395046c4ea7d439065f
Author: Andrew Stubbs <ams@codesourcery.com>
Date: Wed Apr 26 15:23:48 2023 +0100
amdgcn: Fix addsub bug
The vec_fmsubadd instuction actually had add twice, by mistake.
Also improve code-gen for all the complex patterns by using properly
undefined values. Mostly this just prevents the compiler reserving space
in the stack frame.
gcc/ChangeLog:
* config/gcn/gcn-valu.md (cmul<conj_op><mode>3): Use gcn_gen_undef.
(cml<addsub_as><mode>4): Likewise.
(vec_addsub<mode>3): Likewise.
(cadd<rot><mode>3): Likewise.
(vec_fmaddsub<mode>4): Likewise.
(vec_fmsubadd<mode>4): Likewise, and use sub for the odd lanes.
Diff:
---
gcc/config/gcn/gcn-valu.md | 23 +++++++++++++++--------
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/gcc/config/gcn/gcn-valu.md b/gcc/config/gcn/gcn-valu.md
index 44c48468dd6..7290cdc2fd0 100644
--- a/gcc/config/gcn/gcn-valu.md
+++ b/gcc/config/gcn/gcn-valu.md
@@ -2323,8 +2323,9 @@
rtx even = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (even, get_exec (0x5555555555555555UL));
rtx dest = operands[0];
- emit_insn (gen_<cmul_subadd><mode>3_exec (dest, t1, t1_perm, dest, even));
- // a*c-b*d 0
+ emit_insn (gen_<cmul_subadd><mode>3_exec (dest, t1, t1_perm,
+ gcn_gen_undef (<MODE>mode),
+ even)); // a*c-b*d 0
rtx t2_perm = gen_reg_rtx (<MODE>mode);
emit_insn (gen_dpp_swap_pairs<mode> (t2_perm, t2)); // b*c a*d
@@ -2368,7 +2369,8 @@
rtx even = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (even, get_exec (0x5555555555555555UL));
rtx dest = operands[0];
- emit_insn (gen_sub<mode>3_exec (dest, t1, t2_perm, dest, even));
+ emit_insn (gen_sub<mode>3_exec (dest, t1, t2_perm,
+ gcn_gen_undef (<MODE>mode), even));
rtx odd = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (odd, get_exec (0xaaaaaaaaaaaaaaaaUL));
@@ -2392,7 +2394,8 @@
rtx dest = operands[0];
rtx x = operands[1];
rtx y = operands[2];
- emit_insn (gen_sub<mode>3_exec (dest, x, y, dest, even));
+ emit_insn (gen_sub<mode>3_exec (dest, x, y, gcn_gen_undef (<MODE>mode),
+ even));
rtx odd = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (odd, get_exec (0xaaaaaaaaaaaaaaaaUL));
emit_insn (gen_add<mode>3_exec (dest, x, y, dest, odd));
@@ -2419,7 +2422,9 @@
rtx even = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (even, get_exec (0x5555555555555555UL));
- emit_insn (gen_<cadd_subadd><mode>3_exec (dest, x, y, dest, even));
+ emit_insn (gen_<cadd_subadd><mode>3_exec (dest, x, y,
+ gcn_gen_undef (<MODE>mode),
+ even));
rtx odd = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (odd, get_exec (0xaaaaaaaaaaaaaaaaUL));
emit_insn (gen_<cadd_addsub><mode>3_exec (dest, x, y, dest, odd));
@@ -2439,7 +2444,8 @@
rtx even = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (even, get_exec (0x5555555555555555UL));
rtx dest = operands[0];
- emit_insn (gen_sub<mode>3_exec (dest, t1, operands[3], dest, even));
+ emit_insn (gen_sub<mode>3_exec (dest, t1, operands[3],
+ gcn_gen_undef (<MODE>mode), even));
rtx odd = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (odd, get_exec (0xaaaaaaaaaaaaaaaaUL));
emit_insn (gen_add<mode>3_exec (dest, t1, operands[3], dest, odd));
@@ -2459,10 +2465,11 @@
rtx even = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (even, get_exec (0x5555555555555555UL));
rtx dest = operands[0];
- emit_insn (gen_add<mode>3_exec (dest, t1, operands[3], dest, even));
+ emit_insn (gen_add<mode>3_exec (dest, t1, operands[3],
+ gcn_gen_undef (<MODE>mode), even));
rtx odd = gen_rtx_REG (DImode, EXEC_REG);
emit_move_insn (odd, get_exec (0xaaaaaaaaaaaaaaaaUL));
- emit_insn (gen_add<mode>3_exec (dest, t1, operands[3], dest, odd));
+ emit_insn (gen_sub<mode>3_exec (dest, t1, operands[3], dest, odd));
DONE;
})
reply other threads:[~2023-04-27 16:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427163340.98A303858D33@sourceware.org \
--to=ams@gcc.gnu.org \
--cc=gcc-cvs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).