public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-315] testsuite/C++: suppress filename canonicalization in module tests
Date: Fri, 28 Apr 2023 06:53:13 +0000 (GMT)	[thread overview]
Message-ID: <20230428065313.1574C3858C60@sourceware.org> (raw)

https://gcc.gnu.org/g:d76c343d6a6295a8cc612fc19a99156aa0976180

commit r14-315-gd76c343d6a6295a8cc612fc19a99156aa0976180
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Apr 28 08:53:00 2023 +0200

    testsuite/C++: suppress filename canonicalization in module tests
    
    The pathname underneath gcm.cache/ is determined from the effective name
    used for the main input file of a particular module. When modules are
    built, no canonicalization occurs for the main input file. Hence the
    module file wouldn't be found if a different (the canonicalized) file
    name was used when importing that same module. (This is an effect of
    importing happening in the preprocessor, just like #include handling.)
    
    Since it doesn't look easy to make module generation use libcpp's
    maybe_shorter_path() (in fact I'd consider this a layering violation,
    while cloning the logic would - at least in principle - be prone to both
    going out of sync), simply suppress system header path canonicalization
    for the respective tests.
    
    gcc/testsuite/
    
            * g++.dg/modules/alias-1_b.C: Add -fno-canonical-system-headers.
            * g++.dg/modules/alias-1_d.C: Likewise.
            * g++.dg/modules/alias-1_e.C: Likewise.
            * g++.dg/modules/alias-1_f.C: Likewise.
            * g++.dg/modules/cpp-6_c.C: Likewise.
            * g++.dg/modules/dir-only-2_b.C: Likewise.

Diff:
---
 gcc/testsuite/g++.dg/modules/alias-1_b.C    | 2 +-
 gcc/testsuite/g++.dg/modules/alias-1_d.C    | 2 +-
 gcc/testsuite/g++.dg/modules/alias-1_e.C    | 2 +-
 gcc/testsuite/g++.dg/modules/alias-1_f.C    | 2 +-
 gcc/testsuite/g++.dg/modules/cpp-6_c.C      | 2 +-
 gcc/testsuite/g++.dg/modules/dir-only-2_b.C | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/gcc/testsuite/g++.dg/modules/alias-1_b.C b/gcc/testsuite/g++.dg/modules/alias-1_b.C
index b3d7c2df353..1a5c6aa85e6 100644
--- a/gcc/testsuite/g++.dg/modules/alias-1_b.C
+++ b/gcc/testsuite/g++.dg/modules/alias-1_b.C
@@ -1,4 +1,4 @@
-// { dg-additional-options "-fmodules-ts -fdump-lang-module -isystem [srcdir]" }
+// { dg-additional-options "-fmodules-ts -fdump-lang-module -isystem [srcdir] -fno-canonical-system-headers" }
 
 // Alias at the header file.  We have one CMI file
 import "alias-1_a.H";
diff --git a/gcc/testsuite/g++.dg/modules/alias-1_d.C b/gcc/testsuite/g++.dg/modules/alias-1_d.C
index 9b481e5b185..3ed74ee9006 100644
--- a/gcc/testsuite/g++.dg/modules/alias-1_d.C
+++ b/gcc/testsuite/g++.dg/modules/alias-1_d.C
@@ -1,4 +1,4 @@
-// { dg-additional-options "-fmodules-ts -isystem [srcdir]" }
+// { dg-additional-options "-fmodules-ts -isystem [srcdir] -fno-canonical-system-headers" }
 // { dg-module-cmi kevin }
 
 export module kevin;
diff --git a/gcc/testsuite/g++.dg/modules/alias-1_e.C b/gcc/testsuite/g++.dg/modules/alias-1_e.C
index 862ae32882f..2abcb9b9142 100644
--- a/gcc/testsuite/g++.dg/modules/alias-1_e.C
+++ b/gcc/testsuite/g++.dg/modules/alias-1_e.C
@@ -1,4 +1,4 @@
-// { dg-additional-options "-fmodules-ts -isystem [srcdir]" }
+// { dg-additional-options "-fmodules-ts -isystem [srcdir] -fno-canonical-system-headers" }
 
 import bob;
 import kevin;
diff --git a/gcc/testsuite/g++.dg/modules/alias-1_f.C b/gcc/testsuite/g++.dg/modules/alias-1_f.C
index 4c694d1a903..ac30a6b24e7 100644
--- a/gcc/testsuite/g++.dg/modules/alias-1_f.C
+++ b/gcc/testsuite/g++.dg/modules/alias-1_f.C
@@ -1,4 +1,4 @@
-// { dg-additional-options "-fmodules-ts -fdump-lang-module -isystem [srcdir]" }
+// { dg-additional-options "-fmodules-ts -fdump-lang-module -isystem [srcdir] -fno-canonical-system-headers" }
 
 import kevin;
 import bob;
diff --git a/gcc/testsuite/g++.dg/modules/cpp-6_c.C b/gcc/testsuite/g++.dg/modules/cpp-6_c.C
index f9b1e2d68b7..2a34bb87ee4 100644
--- a/gcc/testsuite/g++.dg/modules/cpp-6_c.C
+++ b/gcc/testsuite/g++.dg/modules/cpp-6_c.C
@@ -1,5 +1,5 @@
 // { dg-do preprocess }
-// { dg-additional-options "-fmodules-ts -isystem [srcdir]" }
+// { dg-additional-options "-fmodules-ts -isystem [srcdir] -fno-canonical-system-headers" }
 
 #define empty
 #define nop(X) X
diff --git a/gcc/testsuite/g++.dg/modules/dir-only-2_b.C b/gcc/testsuite/g++.dg/modules/dir-only-2_b.C
index 0691f76ae36..1009ae5b3a2 100644
--- a/gcc/testsuite/g++.dg/modules/dir-only-2_b.C
+++ b/gcc/testsuite/g++.dg/modules/dir-only-2_b.C
@@ -1,5 +1,5 @@
 // { dg-do preprocess }
-// { dg-additional-options "-fmodules-ts -fdirectives-only -isystem [srcdir]" }
+// { dg-additional-options "-fmodules-ts -fdirectives-only -isystem [srcdir] -fno-canonical-system-headers" }
 // a comment
 module; // line
 frob

                 reply	other threads:[~2023-04-28  6:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428065313.1574C3858C60@sourceware.org \
    --to=jbeulich@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).