From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1734) id D73513858D1E; Mon, 1 May 2023 21:52:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D73513858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1682977920; bh=fdhNdlFQ8vcAfC9SG1FQJwdLLJQhzQfE7g2I9gu9ugY=; h=From:To:Subject:Date:From; b=DoCOSjRjtI0/6fqq8U8uGTdbrMHbVKv9E/8Y1Qc2q3LggcCe3Om0LEXwSzmVDXBrY yApA07X/kAIJ9ZX1gL54PWn3duwzUOIr3204//Y3evhTflLPC/dd0w2iVDbpXi2cde lUqQcMMxP9db0OvqMf3MDwar52pmPyVNkefKDs40= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marek Polacek To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-387] ubsan: ubsan_maybe_instrument_array_ref tweak X-Act-Checkin: gcc X-Git-Author: Marek Polacek X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 07c52d1eec9671af92b7ce977b469f13a87887ad X-Git-Newrev: 8d2793ef6b15dbdd347c854f663eb145af5ee593 Message-Id: <20230501215200.D73513858D1E@sourceware.org> Date: Mon, 1 May 2023 21:52:00 +0000 (GMT) List-Id: https://gcc.gnu.org/g:8d2793ef6b15dbdd347c854f663eb145af5ee593 commit r14-387-g8d2793ef6b15dbdd347c854f663eb145af5ee593 Author: Marek Polacek Date: Thu Mar 9 18:43:34 2023 -0500 ubsan: ubsan_maybe_instrument_array_ref tweak In we discussed that the copy_node in ubsan_maybe_instrument_array_ref is redundant, but also that it'd be best to postpone the optimization to GCC 14. So I'm making that change now. gcc/c-family/ChangeLog: * c-ubsan.cc (ubsan_maybe_instrument_array_ref): Don't copy_node. Diff: --- gcc/c-family/c-ubsan.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gcc/c-family/c-ubsan.cc b/gcc/c-family/c-ubsan.cc index c3ae515306c..cfb7cbf389c 100644 --- a/gcc/c-family/c-ubsan.cc +++ b/gcc/c-family/c-ubsan.cc @@ -505,12 +505,8 @@ ubsan_maybe_instrument_array_ref (tree *expr_p, bool ignore_off_by_one) tree e = ubsan_instrument_bounds (EXPR_LOCATION (*expr_p), op0, &op1, ignore_off_by_one); if (e != NULL_TREE) - { - tree t = copy_node (*expr_p); - TREE_OPERAND (t, 1) = build2 (COMPOUND_EXPR, TREE_TYPE (op1), - e, op1); - *expr_p = t; - } + TREE_OPERAND (*expr_p, 1) = build2 (COMPOUND_EXPR, TREE_TYPE (op1), + e, op1); } }