From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 283B33858C74; Tue, 2 May 2023 09:56:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 283B33858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683021399; bh=0iS76JNSMAEWwxkRKH4Rks+AWPXAeglQIKvzRHQVUpo=; h=From:To:Subject:Date:From; b=NK4a9uZbmt4O5rm7E8b+DJ/SesDwZnmEtH4hnbM1BLK8z7IaUXOD3sMeqB1VXewZk QDCi82d+8NVqE8CsoOtLRR+0XNJHbIxyvxm6qhQgqjGHsmV9ceUUy6jsVCkRxBhwJt PjXHjg6BWpxni9vZZx17sB5enyDizloQPjPtcLO4= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-391] tree-optimization/109672 - properly check emulated plus during vect X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 59912ce42eee7f763f8b85f5aa4fd4fcbcffe5b7 X-Git-Newrev: f385252b2336a4a57a30fddf82e558c73bcc85cc Message-Id: <20230502095639.283B33858C74@sourceware.org> Date: Tue, 2 May 2023 09:56:39 +0000 (GMT) List-Id: https://gcc.gnu.org/g:f385252b2336a4a57a30fddf82e558c73bcc85cc commit r14-391-gf385252b2336a4a57a30fddf82e558c73bcc85cc Author: Richard Biener Date: Tue May 2 10:34:48 2023 +0200 tree-optimization/109672 - properly check emulated plus during vect The following refactors the check for emulated vector support for the cases of plus, minus and negate. In the PR we end up with a SImode plus, supported by the target but emulated and in this context fail to verify we are dealing with exactly word_mode. PR tree-optimization/109672 * tree-vect-stmts.cc (vectorizable_operation): For plus, minus and negate always check the vector mode is word mode. Diff: --- gcc/tree-vect-stmts.cc | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index c71e28737ee..3ad6a7d28d7 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -6384,29 +6384,26 @@ vectorizable_operation (vec_info *vinfo, } bool using_emulated_vectors_p = vect_emulated_vector_p (vectype); - if (!target_support_p) + if (!target_support_p || using_emulated_vectors_p) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, - "op not supported by target.\n"); + "op not supported by target.\n"); /* Check only during analysis. */ - if (maybe_ne (GET_MODE_SIZE (vec_mode), UNITS_PER_WORD) + if (((code == PLUS_EXPR || code == MINUS_EXPR || code == NEGATE_EXPR) + && maybe_ne (GET_MODE_SIZE (vec_mode), UNITS_PER_WORD)) || (!vec_stmt && !vect_can_vectorize_without_simd_p (code))) - return false; + { + if (dump_enabled_p ()) + dump_printf (MSG_NOTE, "using word mode not possible.\n"); + return false; + } if (dump_enabled_p ()) dump_printf_loc (MSG_NOTE, vect_location, "proceeding using word mode.\n"); using_emulated_vectors_p = true; } - if (using_emulated_vectors_p - && !vect_can_vectorize_without_simd_p (code)) - { - if (dump_enabled_p ()) - dump_printf (MSG_NOTE, "using word mode not possible.\n"); - return false; - } - int reduc_idx = STMT_VINFO_REDUC_IDX (stmt_info); vec_loop_masks *masks = (loop_vinfo ? &LOOP_VINFO_MASKS (loop_vinfo) : NULL); internal_fn cond_fn = get_conditional_internal_fn (code);