From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1652) id AEA683858D28; Thu, 25 May 2023 05:51:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AEA683858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684993875; bh=4orVBlFAhrgFzRPxerQoLfATZ/e0f0Vv9ei4GJm7flE=; h=From:To:Subject:Date:From; b=N9fPYxTtzQMNHvTolagTrlRVzG6r9ZYHcLRo5rATLviC69Ll4bQNcFpi9lrj/cdve F5a3XrpC++FriAj+wY1SWjuXREVGs1awmb9DVKm8k+Eo2lXKkDUittmliQiPyp6jis IpS+uJEsYoBG4davm9XJxPHEWrhZVkCoHeJI8ONo= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Christophe Lyon To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1192] testsuite, analyzer: Fix testcases with fclose X-Act-Checkin: gcc X-Git-Author: Christophe Lyon X-Git-Refname: refs/heads/master X-Git-Oldrev: e11685f71a561007b36f02e5ef3f5154313b0d41 X-Git-Newrev: c9a19621a07e246385ae075b61283140b23c3b5a Message-Id: <20230525055115.AEA683858D28@sourceware.org> Date: Thu, 25 May 2023 05:51:15 +0000 (GMT) List-Id: https://gcc.gnu.org/g:c9a19621a07e246385ae075b61283140b23c3b5a commit r14-1192-gc9a19621a07e246385ae075b61283140b23c3b5a Author: Christophe Lyon Date: Tue May 23 09:20:05 2023 +0000 testsuite, analyzer: Fix testcases with fclose The gcc.dg/analyzer/data-model-4.c and gcc.dg/analyzer/torture/conftest-1.c fail with recent glibc headers and succeed with older headers. The new error message is: warning: use of possibly-NULL 'f' where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument] Like similar previous fixes in this area, this patch updates the testcase so that this warning isn't reported. 2023-05-23 Christophe Lyon gcc/testsuite/ * gcc.dg/analyzer/data-model-4.c: Exit if fopen returns NULL. * gcc.dg/analyzer/torture/conftest-1.c: Likewise. Diff: --- gcc/testsuite/gcc.dg/analyzer/data-model-4.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/gcc/testsuite/gcc.dg/analyzer/data-model-4.c b/gcc/testsuite/gcc.dg/analyzer/data-model-4.c index 33f90871dfb..d41868d6dbc 100644 --- a/gcc/testsuite/gcc.dg/analyzer/data-model-4.c +++ b/gcc/testsuite/gcc.dg/analyzer/data-model-4.c @@ -8,6 +8,8 @@ int main () { FILE *f = fopen ("conftest.out", "w"); + if (f == NULL) + return 1; return ferror (f) || fclose (f) != 0; ; diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c b/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c index 0cf85f0ebe1..9631bcf73e0 100644 --- a/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c +++ b/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c @@ -3,6 +3,8 @@ int main () { FILE *f = fopen ("conftest.out", "w"); + if (f == NULL) + return 1; return ferror (f) || fclose (f) != 0; ;