public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Law <law@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Fix warning in riscv.md
Date: Tue, 30 May 2023 13:57:58 +0000 (GMT)	[thread overview]
Message-ID: <20230530135758.29E91385840A@sourceware.org> (raw)

https://gcc.gnu.org/g:6b651d6bdecc399edc1cf783cf7fcfe590668a5e

commit 6b651d6bdecc399edc1cf783cf7fcfe590668a5e
Author: From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Date:   Tue May 30 10:16:09 2023 +0800

    RISC-V: Fix warning in riscv.md
    
    Notice there is warning:
    ../../../riscv-gcc/gcc/config/riscv/riscv.md:1356:32: warning:
    comparison between signed and unsigned integer expressions
    [-Wsign-compare]
           if (INTVAL (operands[2]) == GET_MODE_MASK (HImode))
    ../../../riscv-gcc/gcc/config/riscv/riscv.md:1358:37: warning:
    comparison between signed and unsigned integer expressions
    [-Wsign-compare]
           else if (INTVAL (operands[2]) == GET_MODE_MASK (SImode))
    ../../../riscv-gcc/gcc/config/riscv/riscv.md: In function ‘rtx_def*
    gen_anddi3(rtx, rtx, rtx)’:
    ../../../riscv-gcc/gcc/config/riscv/riscv.md:1356:32: warning:
    comparison between signed and unsigned integer expressions
    [-Wsign-compare]
           if (INTVAL (operands[2]) == GET_MODE_MASK (HImode))
    ../../../riscv-gcc/gcc/config/riscv/riscv.md:1358:37: warning:
    comparison between signed and unsigned integer expressions
    [-Wsign-compare]
           else if (INTVAL (operands[2]) == GET_MODE_MASK (SImode))
    
    Add unsigned conversion to fix this warning.
    
    Signed-off-by: Juzhe-Zhong <juzhe.zhong@rivai.ai>
    
    gcc/ChangeLog:
    
            * config/riscv/riscv.md: Fix signed and unsigned comparison
            warning.

Diff:
---
 gcc/config/riscv/riscv.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md
index aba203318a7..f545874edc1 100644
--- a/gcc/config/riscv/riscv.md
+++ b/gcc/config/riscv/riscv.md
@@ -1353,9 +1353,9 @@
   if (CONST_INT_P (operands[2]))
     {
       enum machine_mode tmode = VOIDmode;
-      if (INTVAL (operands[2]) == GET_MODE_MASK (HImode))
+      if (UINTVAL (operands[2]) == GET_MODE_MASK (HImode))
 	tmode = HImode;
-      else if (INTVAL (operands[2]) == GET_MODE_MASK (SImode))
+      else if (UINTVAL (operands[2]) == GET_MODE_MASK (SImode))
 	tmode = SImode;
 
       if (tmode != VOIDmode)

             reply	other threads:[~2023-05-30 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 13:57 Jeff Law [this message]
2023-07-14  2:40 Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230530135758.29E91385840A@sourceware.org \
    --to=law@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).