public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Gaius Mulley <gaius@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1520] PR modula2/110003 Wrong source line listed for unused parameters Date: Sat, 3 Jun 2023 14:28:42 +0000 (GMT) [thread overview] Message-ID: <20230603142842.630B83858D32@sourceware.org> (raw) https://gcc.gnu.org/g:7c0e2159afb3235950d3d8f61ef085cd1ccf0dfc commit r14-1520-g7c0e2159afb3235950d3d8f61ef085cd1ccf0dfc Author: Gaius Mulley <gaiusmod2@gmail.com> Date: Sat Jun 3 15:27:58 2023 +0100 PR modula2/110003 Wrong source line listed for unused parameters Ensure that the parameter token position is recorded for both definition and implementation modules. The shadow variable is created inside BuildFormalParameterSection. The shadow variable needs to have the other definition or implementation module token position set when CheckFormalParameterSection is called. This allows the MetaError family of procedures to request the implementation module token position when reporting unused parameters. gcc/m2/ChangeLog: PR modula2/110003 * gm2-compiler/P2SymBuild.mod (GetParameterShadowVar): Import. (CheckFormalParameterSection): Call PutDeclared for the shadow variable associated with the parameter. Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com> Diff: --- gcc/m2/gm2-compiler/P2SymBuild.mod | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gcc/m2/gm2-compiler/P2SymBuild.mod b/gcc/m2/gm2-compiler/P2SymBuild.mod index de56cc46c5c..98a51ea2ca1 100644 --- a/gcc/m2/gm2-compiler/P2SymBuild.mod +++ b/gcc/m2/gm2-compiler/P2SymBuild.mod @@ -59,7 +59,7 @@ FROM SymbolTable IMPORT NulSym, MakeSubrange, MakeVar, MakeType, PutType, MakeModuleCtor, - PutMode, PutDeclared, + PutMode, PutDeclared, GetParameterShadowVar, PutFieldEnumeration, PutSubrange, PutVar, PutConst, PutConstSet, PutConstructor, IsDefImp, IsType, IsRecord, IsRecordField, IsPointer, @@ -1820,14 +1820,15 @@ BEGIN (* different parameter names *) FailParameter('', 'the parameter has been declared with a different name', - OperandT(pi), ParamTotal+i, ProcSym) + OperandT (pi), ParamTotal+i, ProcSym) END ELSE - IF GetSymName(ParamI)=NulName + IF GetSymName (ParamI) = NulName THEN - PutParamName (OperandTok (pi), ProcSym, ParamTotal+i, OperandT(pi)) + PutParamName (OperandTok (pi), ProcSym, ParamTotal+i, OperandT (pi)) END END ; + PutDeclared (OperandTok (pi), GetParameterShadowVar (ParamI)) ; IF Unbounded THEN (* GetType(ParamI) yields an UnboundedSym or a PartialUnboundedSym,
reply other threads:[~2023-06-03 14:28 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230603142842.630B83858D32@sourceware.org \ --to=gaius@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).