public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jeff Law <law@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1533] Convert H8 port to LRA Date: Sun, 4 Jun 2023 17:42:01 +0000 (GMT) [thread overview] Message-ID: <20230604174201.909723858D32@sourceware.org> (raw) https://gcc.gnu.org/g:f66e0a94ad7bc18538c8207fc2c86b62e4a51bb2 commit r14-1533-gf66e0a94ad7bc18538c8207fc2c86b62e4a51bb2 Author: Jeff Law <jlaw@ventanamicro.com> Date: Sun Jun 4 11:38:55 2023 -0600 Convert H8 port to LRA With Vlad's recent LRA fix to the elimination code, the H8 can be converted to LRA. This patch has two changes of note. First, this turns Zz into a standard constraint. This helps reloading for the H8/SX movqi pattern. Second, this drops the whole pattern for the SX bit memory operations. I can't see why those exist to begin with. They should be handled by the standard bit manipulation patterns. If someone wants to try and improve SX bit support, that'd be great and they can do so within the LRA framework :-) Pushed to the trunk... gcc/ * config/h8300/constraints.md (Zz): Make this a normal constraint. * config/h8300/h8300.cc (TARGET_LRA_P): Remove. * config/h8300/logical.md (H8/SX bit patterns): Remove. Diff: --- gcc/config/h8300/constraints.md | 2 +- gcc/config/h8300/h8300.cc | 3 --- gcc/config/h8300/logical.md | 30 ------------------------------ 3 files changed, 1 insertion(+), 34 deletions(-) diff --git a/gcc/config/h8300/constraints.md b/gcc/config/h8300/constraints.md index 3aef1205fef..3e2526ccbbc 100644 --- a/gcc/config/h8300/constraints.md +++ b/gcc/config/h8300/constraints.md @@ -211,7 +211,7 @@ (and (match_code "const_int") (match_test "exact_log2 (ival & 0xff) != -1"))) -(define_special_memory_constraint "Zz" +(define_constraint "Zz" "@internal" (and (match_test "TARGET_H8300SX") (match_code "mem") diff --git a/gcc/config/h8300/h8300.cc b/gcc/config/h8300/h8300.cc index 7412c0535fc..cdf74c1acbd 100644 --- a/gcc/config/h8300/h8300.cc +++ b/gcc/config/h8300/h8300.cc @@ -5625,9 +5625,6 @@ pre_incdec_with_reg (rtx op, unsigned int reg) #undef TARGET_MODES_TIEABLE_P #define TARGET_MODES_TIEABLE_P h8300_modes_tieable_p -#undef TARGET_LRA_P -#define TARGET_LRA_P hook_bool_void_false - #undef TARGET_LEGITIMATE_ADDRESS_P #define TARGET_LEGITIMATE_ADDRESS_P h8300_legitimate_address_p diff --git a/gcc/config/h8300/logical.md b/gcc/config/h8300/logical.md index f07c79e1eac..5df0922ef4e 100644 --- a/gcc/config/h8300/logical.md +++ b/gcc/config/h8300/logical.md @@ -31,28 +31,6 @@ ;; AND INSTRUCTIONS ;; ---------------------------------------------------------------------- -(define_insn "bclr<mode>_msx" - [(set (match_operand:QHI 0 "bit_register_indirect_operand" "=WU") - (and:QHI (match_operand:QHI 1 "bit_register_indirect_operand" "%0") - (match_operand:QHI 2 "single_zero_operand" "Y0")))] - "TARGET_H8300SX && rtx_equal_p (operands[0], operands[1])" - "bclr\\t%W2,%0" - [(set_attr "length" "8")]) - -(define_split - [(set (match_operand:HI 0 "bit_register_indirect_operand") - (and:HI (match_operand:HI 1 "bit_register_indirect_operand") - (match_operand:HI 2 "single_zero_operand")))] - "TARGET_H8300SX && abs (INTVAL (operands[2])) > 0xff" - [(set (match_dup 0) - (and:QI (match_dup 1) - (match_dup 2)))] - { - operands[0] = adjust_address (operands[0], QImode, 0); - operands[1] = adjust_address (operands[1], QImode, 0); - operands[2] = GEN_INT ((INTVAL (operands[2])) >> 8); - }) - (define_insn_and_split "*andqi3_2" [(set (match_operand:QI 0 "bit_operand" "=U,rQ,r") (and:QI (match_operand:QI 1 "bit_operand" "%0,0,WU") @@ -177,14 +155,6 @@ ;; OR/XOR INSTRUCTIONS ;; ---------------------------------------------------------------------- -(define_insn "b<code><mode>_msx" - [(set (match_operand:QHI 0 "bit_register_indirect_operand" "=WU") - (ors:QHI (match_operand:QHI 1 "bit_register_indirect_operand" "%0") - (match_operand:QHI 2 "single_one_operand" "Y2")))] - "TARGET_H8300SX && rtx_equal_p (operands[0], operands[1])" - { return <CODE> == IOR ? "bset\\t%V2,%0" : "bnot\\t%V2,%0"; } - [(set_attr "length" "8")]) - (define_insn_and_split "<code>qi3_1" [(set (match_operand:QI 0 "bit_operand" "=U,rQ") (ors:QI (match_operand:QI 1 "bit_operand" "%0,0")
reply other threads:[~2023-06-04 17:42 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230604174201.909723858D32@sourceware.org \ --to=law@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).