public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1599] For the `-A CMP -B -> B CMP A` pattern allow EQ/NE for all integer types Date: Wed, 7 Jun 2023 02:58:59 +0000 (GMT) [thread overview] Message-ID: <20230607025859.CFC9B3858C54@sourceware.org> (raw) https://gcc.gnu.org/g:cc155ff9c38848a8e6a7125dd0b66ac0aef47880 commit r14-1599-gcc155ff9c38848a8e6a7125dd0b66ac0aef47880 Author: Andrew Pinski <apinski@marvell.com> Date: Mon Jun 5 19:12:43 2023 -0700 For the `-A CMP -B -> B CMP A` pattern allow EQ/NE for all integer types I noticed while looking at some code generation issue, that forwprop was not handling `-a == 0` for unsigned types and I was confused why it was not. r6-1814-g66e1cacf608045 removed these from fold because they were supposed to be already handled by the match.pd patterns but it was missed that the match.pd patterns checked TYPE_OVERFLOW_UNDEFINED while fold didn't do that for NE/EQ. This patch removes the restriction on NE/EQ on TYPE_OVERFLOW_UNDEFINED. OK? Bootstrapped and tested on x86_64-linux-gnu. gcc/ChangeLog: PR tree-optimization/110134 * match.pd (-A CMP -B -> B CMP A): Allow EQ/NE for all integer types. (-A CMP CST -> B CMP (-CST)): Likewise. gcc/testsuite/ChangeLog: PR tree-optimization/110134 * gcc.dg/tree-ssa/negneq-1.c: New test. * gcc.dg/tree-ssa/negneq-2.c: New test. * gcc.dg/tree-ssa/negneq-3.c: New test. * gcc.dg/tree-ssa/negneq-4.c: New test. Diff: --- gcc/match.pd | 8 ++++++-- gcc/testsuite/gcc.dg/tree-ssa/negneq-1.c | 17 +++++++++++++++++ gcc/testsuite/gcc.dg/tree-ssa/negneq-2.c | 17 +++++++++++++++++ gcc/testsuite/gcc.dg/tree-ssa/negneq-3.c | 20 ++++++++++++++++++++ gcc/testsuite/gcc.dg/tree-ssa/negneq-4.c | 20 ++++++++++++++++++++ 5 files changed, 80 insertions(+), 2 deletions(-) diff --git a/gcc/match.pd b/gcc/match.pd index 941f1be9f8e..dc36927cd0f 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -5919,13 +5919,17 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (cmp (negate @0) (negate @1)) (if (FLOAT_TYPE_P (TREE_TYPE (@0)) || (ANY_INTEGRAL_TYPE_P (TREE_TYPE (@0)) - && TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (@0)))) + && (cmp == EQ_EXPR + || cmp == NE_EXPR + || TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (@0))))) (scmp @0 @1))) (simplify (cmp (negate @0) CONSTANT_CLASS_P@1) (if (FLOAT_TYPE_P (TREE_TYPE (@0)) || (ANY_INTEGRAL_TYPE_P (TREE_TYPE (@0)) - && TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (@0)))) + && (cmp == EQ_EXPR + || cmp == NE_EXPR + || TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (@0))))) (with { tree tem = const_unop (NEGATE_EXPR, TREE_TYPE (@0), @1); } (if (tem && !TREE_OVERFLOW (tem)) (scmp @0 { tem; })))))) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/negneq-1.c b/gcc/testsuite/gcc.dg/tree-ssa/negneq-1.c new file mode 100644 index 00000000000..94ff57d511b --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/negneq-1.c @@ -0,0 +1,17 @@ +/* PR tree-optimization/110134 */ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +int fu(unsigned a) +{ + a = -a; + return a != 0; +} +int fs(signed a) +{ + a = -a; + return a != 0; +} + +/* We should have optimized out the a = -a; statements. */ +/* { dg-final { scan-tree-dump-not "= -a" "optimized" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/negneq-2.c b/gcc/testsuite/gcc.dg/tree-ssa/negneq-2.c new file mode 100644 index 00000000000..9a3bb481ce4 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/negneq-2.c @@ -0,0 +1,17 @@ +/* PR tree-optimization/110134 */ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +int fu(unsigned a) +{ + a = -a; + return a == 1; +} +int fs(signed a) +{ + a = -a; + return a == 1; +} + +/* We should have optimized out the a = -a; statements. */ +/* { dg-final { scan-tree-dump-not "= -a" "optimized" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/negneq-3.c b/gcc/testsuite/gcc.dg/tree-ssa/negneq-3.c new file mode 100644 index 00000000000..14546a606c3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/negneq-3.c @@ -0,0 +1,20 @@ +/* PR tree-optimization/110134 */ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +int fu(unsigned a, unsigned b) +{ + a = -a; + b = -b; + return a == b; +} +int fs(signed a, signed b) +{ + a = -a; + b = -b; + return a == b; +} + +/* We should have optimized out the a = -; statements. */ +/* { dg-final { scan-tree-dump-not "= -a" "optimized" } } */ +/* { dg-final { scan-tree-dump-not "= -b" "optimized" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/negneq-4.c b/gcc/testsuite/gcc.dg/tree-ssa/negneq-4.c new file mode 100644 index 00000000000..1b66854acae --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/negneq-4.c @@ -0,0 +1,20 @@ +/* PR tree-optimization/110134 */ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +int fu(unsigned a, unsigned b) +{ + a = -a; + b = -b; + return a != b; +} +int fs(signed a, signed b) +{ + a = -a; + b = -b; + return a != b; +} + +/* We should have optimized out the a = -; statements. */ +/* { dg-final { scan-tree-dump-not "= -a" "optimized" } } */ +/* { dg-final { scan-tree-dump-not "= -b" "optimized" } } */
reply other threads:[~2023-06-07 2:58 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230607025859.CFC9B3858C54@sourceware.org \ --to=pinskia@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).