From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1816) id 83E973858C62; Thu, 8 Jun 2023 08:54:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83E973858C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686214471; bh=b5JVUvw0nkZs19Uhw7F+vSsMWj3V/zjh65iZf593YyE=; h=From:To:Subject:Date:From; b=tpqnf9ucARyVLxO9eBj63+D2HjXLlu3lzAN/55ghEdsJt5uXPS55WxkrEioDvvssp kYq65aqY1Cpr1G0jpWzwSPs6ta8mEa3jhRNgPc1GcznHmqJpK66HpfuVA7Rf/rcMzl PPmY2BlWDMA2p4aRDxbwFbJOxttFlWapjvH59Aco= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Kyrylo Tkachov To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-9683] arm: PR target/109939 Correct signedness of return type of __ssat intrinsics X-Act-Checkin: gcc X-Git-Author: Kyrylo Tkachov X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: 7e464d07d6acb1a209e28f88a686593fce19c658 X-Git-Newrev: a620451032abb28343c31438a4e779ea5d2e1bbf Message-Id: <20230608085431.83E973858C62@sourceware.org> Date: Thu, 8 Jun 2023 08:54:31 +0000 (GMT) List-Id: https://gcc.gnu.org/g:a620451032abb28343c31438a4e779ea5d2e1bbf commit r12-9683-ga620451032abb28343c31438a4e779ea5d2e1bbf Author: Kyrylo Tkachov Date: Wed May 24 09:33:04 2023 +0100 arm: PR target/109939 Correct signedness of return type of __ssat intrinsics As the PR says we shouldn't be using qualifier_unsigned for the return type of the __ssat intrinsics. UNSIGNED_SAT_BINOP_UNSIGNED_IMM_QUALIFIERS already exists for that. This was just a thinko. This patch fixes this and the warning with -Wconversion goes away. Bootstrapped and tested on arm-none-linux-gnueabihf. gcc/ChangeLog: PR target/109939 * config/arm/arm-builtins.cc (SAT_BINOP_UNSIGNED_IMM_QUALIFIERS): Use qualifier_none for the return operand. gcc/testsuite/ChangeLog: PR target/109939 * gcc.target/arm/pr109939.c: New test. (cherry picked from commit 95542a6ec4b350c653b793b7c36a8210b0e9a89d) Diff: --- gcc/config/arm/arm-builtins.cc | 2 +- gcc/testsuite/gcc.target/arm/pr109939.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/gcc/config/arm/arm-builtins.cc b/gcc/config/arm/arm-builtins.cc index 36a40a1dc80..557d6f68fd1 100644 --- a/gcc/config/arm/arm-builtins.cc +++ b/gcc/config/arm/arm-builtins.cc @@ -97,7 +97,7 @@ arm_binop_imm_qualifiers[SIMD_MAX_BUILTIN_ARGS] /* T (T, unsigned immediate). */ static enum arm_type_qualifiers arm_sat_binop_imm_qualifiers[SIMD_MAX_BUILTIN_ARGS] - = { qualifier_unsigned, qualifier_none, qualifier_unsigned_immediate }; + = { qualifier_none, qualifier_none, qualifier_unsigned_immediate }; #define SAT_BINOP_UNSIGNED_IMM_QUALIFIERS \ (arm_sat_binop_imm_qualifiers) diff --git a/gcc/testsuite/gcc.target/arm/pr109939.c b/gcc/testsuite/gcc.target/arm/pr109939.c new file mode 100644 index 00000000000..aafda7cd3cd --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr109939.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target arm_sat_ok } */ +/* { dg-add-options arm_sat } */ +/* { dg-additional-options "-O -Wall -Wconversion" } */ + +#include + +int dbg_ssat_out; +int dbg_ssat_in; + +void test_arm_ssat(void) +{ + dbg_ssat_out = __ssat(dbg_ssat_in, 16); +}