From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1005) id 1CABA3858C62; Thu, 8 Jun 2023 16:54:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CABA3858C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686243298; bh=RnFOPXrDKeF+eV2TQx7Xoyf4c1Bevyyb1MaCwsdhSss=; h=From:To:Subject:Date:From; b=PMThgnhkR9pUYfZgvUTPpNPXz/s3DABIfKXkmpJd13FA8rnFVaMxyyDydS4U03I/p cOf9NCubi8MKDPs/vvGPMdUoRS15d977HJ1nTX90qEfwVKJXNuar82WppTRzFKLzeE q3W5vIbjUdjzs597vPBXF/Xla8/gMjUqsgFumcW8= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Michael Meissner To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work122)] Update ChangeLog.meissner X-Act-Checkin: gcc X-Git-Author: Michael Meissner X-Git-Refname: refs/users/meissner/heads/work122 X-Git-Oldrev: 3d58f15f98a3f7a0dc88a88d8a78f9de27a6260e X-Git-Newrev: fb5a0e51cc9f435071cf46090bd8dd0aa99b895a Message-Id: <20230608165458.1CABA3858C62@sourceware.org> Date: Thu, 8 Jun 2023 16:54:58 +0000 (GMT) List-Id: https://gcc.gnu.org/g:fb5a0e51cc9f435071cf46090bd8dd0aa99b895a commit fb5a0e51cc9f435071cf46090bd8dd0aa99b895a Author: Michael Meissner Date: Thu Jun 8 12:54:54 2023 -0400 Update ChangeLog.meissner Diff: --- gcc/ChangeLog.meissner | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner index 1c40084ce43..63644d60a12 100644 --- a/gcc/ChangeLog.meissner +++ b/gcc/ChangeLog.meissner @@ -1,4 +1,4 @@ -==================== Branch work122, patch #1 ==================== +==================== Branch work122, patch #2 ==================== Fix power10 fusion and -fstack-protector, PR target/105325 @@ -6,10 +6,12 @@ This patch fixes an issue where if you use the -fstack-protector and -mcpu=power10 options and you have a large stack frame, the GCC compiler will generate a LWA instruction with a large offset. -There are several problems: +There are several problems with the current GCC: 1) The prefixed attribute was not checking insns with the type - fused_load_cmpi for being load insns. + fused_load_cmpi for being load insns. This meant if the load + compare + fusion was not split, it would not know that the load should be + prefixed. 2) The recognition of LWA for being prefixed looks at the "sign_extend" attribute and whether the register mode was different than the memory @@ -18,7 +20,7 @@ There are several problems: 3) The constraints in fusion.md (generated by genfusion.pl) use "m" for LWA and LD, when they should use "YZ". - 4) There is a lwa_operand that should be used instead of + 4) There is a lwa_operand predicate that should be used instead of ds_form_mem_operand for the LWA instruction. The main fix is to modify genfusion.pl that it sets the appropriate predicates @@ -33,15 +35,15 @@ I set the "sign_extend" attribute on the cases that generate LWA. I modified the "prefixed" attribute so that it also checks fused_load_cmpi. -2023-06-06 Michael Meissner +2023-06-07 Michael Meissner gcc/ * config/rs6000/genfusion.pl (gen_ld_cmpi_p10_one): Fix constraints and predicates for LD and LWA. Optimize LWA/CMPDI to generate LWZ/CMPWI if - we don't need the result of the load after the comparison. Change the - name of the insn pattern to reflect whether a DImode or SImode register - is loaded. Set sign_extend attribute for LWA instruction. + we don't need the result of the load after the comparison. Set the + sign_extend attribute for LWA instruction. For LWA where we do not need + the result of the load after the comparison, use LWZ and CMPWI. * config/rs6000/fusion.md: Regenerate. * config/rs6000/rs6000.md (prefixed attribute): Treat fused_load_cmpi insns as being load insns. @@ -52,6 +54,8 @@ gcc/testsuite/ * gcc.target/powerpc/fusion-p10-ldcmpi.c: Adjust names and insn counts for PR target/105325 fix. +==================== Branch work122, patch #1 was reverted ==================== + ==================== Branch work122, baseline ==================== 2023-06-06 Michael Meissner