From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2078) id F065E3858C20; Fri, 9 Jun 2023 01:42:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F065E3858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686274940; bh=z7mDXfEm1lnmvGVOy05drfzuH5l7KpZMfQ+oU1eFOQ8=; h=From:To:Subject:Date:From; b=NCTzG827EoG/coZMlLhD0yJVqGmbHvNWRPMLtYFhQZMxqIg/v1GQTeZfMjgrsKp9N T4HBZ9+aDR5QhLYHZJ+Tpqrb3PMqT0CrW2ReOY9qOiynkhNjk3+VtdP7zX2D1GfWnL r6vpLKpIqVLTXITTD8vRhBRJ4BUJYww5zAT0Ucd4= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: hongtao Liu To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1641] Explicitly view_convert_expr mask to signed type when folding pblendvb builtins. X-Act-Checkin: gcc X-Git-Author: liuhongt X-Git-Refname: refs/heads/master X-Git-Oldrev: 07b86ab138bf8be8cb331015cd2b9775c6856ac6 X-Git-Newrev: dac73e4c64bf62be18bd5203e4e0f3e6bc64b4dc Message-Id: <20230609014220.F065E3858C20@sourceware.org> Date: Fri, 9 Jun 2023 01:42:20 +0000 (GMT) List-Id: https://gcc.gnu.org/g:dac73e4c64bf62be18bd5203e4e0f3e6bc64b4dc commit r14-1641-gdac73e4c64bf62be18bd5203e4e0f3e6bc64b4dc Author: liuhongt Date: Mon Jun 5 12:38:41 2023 +0800 Explicitly view_convert_expr mask to signed type when folding pblendvb builtins. Since mask < 0 will be always false for vector char when -funsigned-char, but vpblendvb needs to check the most significant bit. The patch explicitly VCE to vector signed char. gcc/ChangeLog: PR target/110108 * config/i386/i386.cc (ix86_gimple_fold_builtin): Explicitly view_convert_expr mask to signed type when folding pblendvb builtins. gcc/testsuite/ChangeLog: * gcc.target/i386/pr110108-2.c: New test. Diff: --- gcc/config/i386/i386.cc | 4 +++- gcc/testsuite/gcc.target/i386/pr110108-2.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 660fe15cce1..3a1444db882 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -18572,8 +18572,10 @@ ix86_gimple_fold_builtin (gimple_stmt_iterator *gsi) tree itype = GET_MODE_INNER (TYPE_MODE (type)) == E_SFmode ? intSI_type_node : intDI_type_node; type = get_same_sized_vectype (itype, type); - arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2); } + else + type = signed_type_for (type); + arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2); tree zero_vec = build_zero_cst (type); tree cmp_type = truth_type_for (type); tree cmp = gimple_build (&stmts, LT_EXPR, cmp_type, arg2, zero_vec); diff --git a/gcc/testsuite/gcc.target/i386/pr110108-2.c b/gcc/testsuite/gcc.target/i386/pr110108-2.c new file mode 100644 index 00000000000..2d1d2fd4991 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr110108-2.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-mavx2 -O2 -funsigned-char" } */ +/* { dg-final { scan-assembler-times "vpblendvb" 2 } } */ + +#include +__m128i do_stuff_128(__m128i X0, __m128i X1, __m128i X2) { + __m128i Result = _mm_blendv_epi8(X0, X1, X2); + return Result; +} + +__m256i do_stuff_256(__m256i X0, __m256i X1, __m256i X2) { + __m256i Result = _mm256_blendv_epi8(X0, X1, X2); + return Result; +}