From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1005) id 484FA3858C20; Fri, 9 Jun 2023 04:18:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 484FA3858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686284292; bh=3mdKWbdRt3t4YCUUJxQX1rGRVS/01LjPlLPJNOr91jE=; h=From:To:Subject:Date:From; b=fIQnILLIFu+5Qlze7+RxPIKMTxd1r80ZI9/fqtCI5dPkzQ8xAvunEXLNmaRGdVM5E yTlYfVAvtIgejr5ZvsywMEiYUKjCT749dkRSjxNXybIflG7gOBdxP32Tu8ujH1tR50 KNpmWZT7axITEbJZl8WOWnLrYh25ItskvgWyoK3I= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Michael Meissner To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work122)] Update ChangeLog.meissner X-Act-Checkin: gcc X-Git-Author: Michael Meissner X-Git-Refname: refs/users/meissner/heads/work122 X-Git-Oldrev: 5a6a3d7f0a6ccc1ddf64f76ff68329d2be949da1 X-Git-Newrev: c2bb4e2b5131154648979c748d2029df2e457abb Message-Id: <20230609041812.484FA3858C20@sourceware.org> Date: Fri, 9 Jun 2023 04:18:12 +0000 (GMT) List-Id: https://gcc.gnu.org/g:c2bb4e2b5131154648979c748d2029df2e457abb commit c2bb4e2b5131154648979c748d2029df2e457abb Author: Michael Meissner Date: Fri Jun 9 00:18:09 2023 -0400 Update ChangeLog.meissner Diff: --- gcc/ChangeLog.meissner | 35 ++++++++++------------------------- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner index 3bca12eb10e..055d3cd71b8 100644 --- a/gcc/ChangeLog.meissner +++ b/gcc/ChangeLog.meissner @@ -1,4 +1,4 @@ -==================== Branch work122, patch #2 ==================== +==================== Branch work122, patch #4 ==================== Fix power10 fusion and -fstack-protector, PR target/105325 @@ -8,48 +8,33 @@ generate a LWA instruction with a large offset. There are several problems with the current GCC: - 1) The prefixed attribute was not checking insns with the type - fused_load_cmpi for being load insns. This meant if the load + compare - fusion was not split, the insn size might be off, and the wrong - instruction might be generated. - - 2) The code in prefixed_load_p looks at the "sign_extend" attribute and - whether the register mode was different than the memory for SImode loads - to detect LWA instructions. - - 3) The constraints in fusion.md (generated by genfusion.pl) use "m" for LWA + 1) The constraints in fusion.md (generated by genfusion.pl) use "m" for LWA and LD, when they should use "YZ". - 4) The code to determine whether to split the insn if it has a prefixed - address was passing in SImode. For LWA, we need to pass in DImode and - not SImode to properly determine if the address is prefixed. + 2) The normal calls to address_is_non_pfx_d_or_x doesn't work with lwa, + because you need to pass in DImode instead of SImode. It is simplified + if you use the lwa_operand predicate instead of ds_form_mem_operand. The fix is to modify genfusion.pl that it sets the "YZ" constraint instead of "m" for the ld and lwa instructions. -I also set the signed attribute on the HI/SImode loads that do sign extension. - -I modified the predicate for lwa to use lwa_operand instead of the predicate -ds_form_mem_operand. This predicate has direct checks to prevent a prefixed lwa -from being generated. I also modified the condition for the insn splitter so -that it passes DImode for the lwa instructions and not SImode. +I modified the genfusion.pl code use to use lwa_operand for the lwa instruction +to prevent prefixed addresses at combine time. -I modified the "prefixed" attribute so that it also checks fused_load_cmpi. - -2023-06-07 Michael Meissner +2023-06-08 Michael Meissner gcc/ * config/rs6000/genfusion.pl (gen_ld_cmpi_p10_one): Fix problems that allowed prefixed lwa to be generated. * config/rs6000/fusion.md: Regenerate. - * config/rs6000/rs6000.md (prefixed attribute): Treat fused_load_cmpi - insns as being load insns. gcc/testsuite/ * g++.target/powerpc/pr105325.C: New test. +==================== Branch work122, patch #3 was reverted ==================== + ==================== Branch work122, patch #2 was reverted ==================== ==================== Branch work122, patch #1 was reverted ====================