From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 4C4D83856DCD; Fri, 9 Jun 2023 07:21:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C4D83856DCD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686295264; bh=NoUXOjQGv8z7mKS+2iIfyFwy9pOoWwRI3sfdj196u14=; h=From:To:Subject:Date:From; b=moHp4ryaDRdYMhYNz1d097LUVL6NX1CQ+mi4XL2Nay5z7TPpGzL0nGSS/nBhkGJa5 EkjdbRy+5SFkdwoCBxQ1cJ9Pd84zzBCB8fgPgrepUdmtsggpPCvzPjmu3NilLtbhYT CHx0nr5KWAwyHwOXQjx6KtzdwGWdcgXopBTVDZ3s= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-7431] fortran: Fix ICE on pr96024.f90 on big-endian hosts [PR96024] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: 5e01a590aa719d235811c1549547f736de2b5190 X-Git-Newrev: 32c51d0911e8d1bdf3f60bc831794b7932416ccd Message-Id: <20230609072104.4C4D83856DCD@sourceware.org> Date: Fri, 9 Jun 2023 07:21:04 +0000 (GMT) List-Id: https://gcc.gnu.org/g:32c51d0911e8d1bdf3f60bc831794b7932416ccd commit r13-7431-g32c51d0911e8d1bdf3f60bc831794b7932416ccd Author: Jakub Jelinek Date: Fri Jun 9 09:10:29 2023 +0200 fortran: Fix ICE on pr96024.f90 on big-endian hosts [PR96024] The pr96024.f90 testcase ICEs on big-endian hosts. The problem is that length->val.integer is accessed after checking length->expr_type == EXPR_CONSTANT, but it is a CHARACTER constant which uses length->val.character union member instead and on big-endian we end up reading constant 0x100000000 rather than some small number on little-endian and if target doesn't have enough memory for 4 times that (i.e. 16GB allocation), it ICEs. 2023-06-09 Jakub Jelinek PR fortran/96024 * primary.cc (gfc_convert_to_structure_constructor): Only do constant string ctor length verification and truncation/padding if constant length has INTEGER type. (cherry picked from commit 4cf6e322adc19f927859e0a5edfa93cec4b8c844) Diff: --- gcc/fortran/primary.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/primary.cc b/gcc/fortran/primary.cc index 00d35a71770..25a2e70cc65 100644 --- a/gcc/fortran/primary.cc +++ b/gcc/fortran/primary.cc @@ -3188,10 +3188,11 @@ gfc_convert_to_structure_constructor (gfc_expr *e, gfc_symbol *sym, gfc_expr **c goto cleanup; /* For a constant string constructor, make sure the length is - correct; truncate of fill with blanks if needed. */ + correct; truncate or fill with blanks if needed. */ if (this_comp->ts.type == BT_CHARACTER && !this_comp->attr.allocatable && this_comp->ts.u.cl && this_comp->ts.u.cl->length && this_comp->ts.u.cl->length->expr_type == EXPR_CONSTANT + && this_comp->ts.u.cl->length->ts.type == BT_INTEGER && actual->expr->ts.type == BT_CHARACTER && actual->expr->expr_type == EXPR_CONSTANT) {