public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] fix frange_nextafter odr violation
Date: Fri,  9 Jun 2023 08:08:24 +0000 (GMT)	[thread overview]
Message-ID: <20230609080824.E3485385660C@sourceware.org> (raw)

https://gcc.gnu.org/g:37d63f69507b9c6384ca74b465f17410b6c85fd0

commit 37d63f69507b9c6384ca74b465f17410b6c85fd0
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Fri Jun 9 02:42:21 2023 -0300

    fix frange_nextafter odr violation
    
    C++ requires inline functions to be declared inline and defined in
    every translation unit that uses them.  frange_nextafter is used in
    gimple-range-op.cc but it's only defined as inline in
    range-op-float.cc.  Drop the extraneous inline specifier.
    
    Other non-static inline functions in range-op-float.cc are not
    referenced elsewhere, so I'm making them static.
    
    
    for  gcc/ChangeLog
    
            * range-op-float.cc (frange_nextafter): Drop inline.
            (frelop_early_resolve): Add static.
            (frange_float): Likewise.

Diff:
---
 gcc/range-op-float.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc
index e0e91bad44d..22cf74b9d4a 100644
--- a/gcc/range-op-float.cc
+++ b/gcc/range-op-float.cc
@@ -255,7 +255,7 @@ maybe_isnan (const frange &op1, const frange &op2)
 // Floating version of relop_early_resolve that takes into account NAN
 // and -ffinite-math-only.
 
-inline bool
+static inline bool
 frelop_early_resolve (irange &r, tree type,
 		      const frange &op1, const frange &op2,
 		      relation_trio rel, relation_kind my_rel)
@@ -272,7 +272,7 @@ frelop_early_resolve (irange &r, tree type,
 
 // Set VALUE to its next real value, or INF if the operation overflows.
 
-inline void
+void
 frange_nextafter (enum machine_mode mode,
 		  REAL_VALUE_TYPE &value,
 		  const REAL_VALUE_TYPE &inf)
@@ -2878,7 +2878,7 @@ namespace selftest
 
 // Build an frange from string endpoints.
 
-inline frange
+static inline frange
 frange_float (const char *lb, const char *ub, tree type = float_type_node)
 {
   REAL_VALUE_TYPE min, max;

             reply	other threads:[~2023-06-09  8:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  8:08 Alexandre Oliva [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-09  6:26 Alexandre Oliva
2023-06-09  6:18 Alexandre Oliva
2023-06-08 12:28 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609080824.E3485385660C@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).