From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id 3CF2C3856DFE; Fri, 9 Jun 2023 14:16:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CF2C3856DFE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686320162; bh=Wgg8KCsAlwuhFDrwoLA+bv/2g7iCwY854vY8DklxDwo=; h=From:To:Subject:Date:From; b=bze55zuwUReiIGMGoKDIQXzLxLJSWDK9PPywBh0ceYefjLriDGOWE3/QHGosKUHjw 1j190uwFHznIjahHpfc0JSG1yXjz8xgOa6dt00QYTN2POl2+w7NDatp8XZP3UyY8N5 n1LGyjoilPlAH8Nu3nAgUaxc+X5WHIVuflb7v1lg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1654] MATCH: Allow unsigned types for `X & -Y -> X * Y` pattern X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 72e652f3425079259faa4edefe1dc571f72f91e0 X-Git-Newrev: 7ceed7e3e29c3375e3b8c4347d1985a72bbe7f11 Message-Id: <20230609141602.3CF2C3856DFE@sourceware.org> Date: Fri, 9 Jun 2023 14:16:02 +0000 (GMT) List-Id: https://gcc.gnu.org/g:7ceed7e3e29c3375e3b8c4347d1985a72bbe7f11 commit r14-1654-g7ceed7e3e29c3375e3b8c4347d1985a72bbe7f11 Author: Andrew Pinski Date: Wed Jun 7 07:58:50 2023 -0700 MATCH: Allow unsigned types for `X & -Y -> X * Y` pattern This allows unsigned types if the inner type where the negation is located has greater than or equal to precision than the outer type. branchless-cond.c needs to be updated since now we change it to use a multiply rather than still having (-a)&c in there. OK? Bootstrapped and tested on x86_64-linux-gnu. gcc/ChangeLog: * match.pd (`X & -Y -> X * Y`): Allow for truncation and the same type for unsigned types. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/branchless-cond.c: Update testcase. Diff: --- gcc/match.pd | 5 ++++- gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gcc/match.pd b/gcc/match.pd index 335e3535184..77030b3b50b 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -2065,7 +2065,10 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (if (INTEGRAL_TYPE_P (type) && INTEGRAL_TYPE_P (TREE_TYPE (@0)) && TREE_CODE (TREE_TYPE (@0)) != BOOLEAN_TYPE - && !TYPE_UNSIGNED (TREE_TYPE (@0))) + /* Sign extending of the neg or a truncation of the neg + is needed. */ + && (!TYPE_UNSIGNED (TREE_TYPE (@0)) + || TYPE_PRECISION (type) <= TYPE_PRECISION (TREE_TYPE (@0)))) (mult (convert @0) @1))) /* Narrow integer multiplication by a zero_one_valued_p operand. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c b/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c index 68087ae6568..e063dc4bb5f 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c @@ -21,6 +21,6 @@ int f4(unsigned int x, unsigned int y, unsigned int z) return ((x & 1) != 0) ? z | y : y; } -/* { dg-final { scan-tree-dump-times " -" 4 "optimized" } } */ -/* { dg-final { scan-tree-dump-times " & " 8 "optimized" } } */ -/* { dg-final { scan-tree-dump-not "if" "optimized" } } */ +/* { dg-final { scan-tree-dump-times " \\\*" 4 "optimized" } } */ +/* { dg-final { scan-tree-dump-times " & " 4 "optimized" } } */ +/* { dg-final { scan-tree-dump-not "if " "optimized" } } */