public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Roger Sayle <sayle@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-1791] Avoid duplicate vector initializations during RTL expansion.
Date: Tue, 13 Jun 2023 16:22:14 +0000 (GMT)	[thread overview]
Message-ID: <20230613162214.980B23858D38@sourceware.org> (raw)

https://gcc.gnu.org/g:40eafcd83d6ee644ec48985fd5a9696921ea10e7

commit r14-1791-g40eafcd83d6ee644ec48985fd5a9696921ea10e7
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Tue Jun 13 17:20:31 2023 +0100

    Avoid duplicate vector initializations during RTL expansion.
    
    This middle-end patch avoids some redundant RTL for vector initialization
    during RTL expansion.  For the simple test case:
    
    typedef __int128 v1ti __attribute__ ((__vector_size__ (16)));
    __int128 key;
    
    v1ti foo() {
        return (v1ti){key};
    }
    
    the middle-end currently expands:
    
    (set (reg:V1TI 85) (const_vector:V1TI [ (const_int 0) ]))
    
    (set (reg:V1TI 85) (mem/c:V1TI (symbol_ref:DI ("key"))))
    
    where we create a dead instruction that initializes the vector to zero,
    immediately followed by a set of the entire vector.  This patch skips
    this zeroing instruction when the vector has only a single element.
    It also updates the code to indicate when we've cleared the vector,
    so that we don't need to initialize zero elements.
    
    2023-06-13  Roger Sayle  <roger@nextmovesoftware.com>
    
    gcc/ChangeLog
            * expr.cc (store_constructor) <case VECTOR_TYPE>: Don't bother
            clearing vectors with only a single element.  Set CLEARED if the
            vector was initialized to zero.

Diff:
---
 gcc/expr.cc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gcc/expr.cc b/gcc/expr.cc
index 868fa6e4cca..62cd8facf75 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -7531,8 +7531,11 @@ store_constructor (tree exp, rtx target, int cleared, poly_int64 size,
 	  }
 
 	/* Inform later passes that the old value is dead.  */
-	if (!cleared && !vector && REG_P (target))
-	  emit_move_insn (target, CONST0_RTX (mode));
+	if (!cleared && !vector && REG_P (target) && maybe_gt (n_elts, 1u))
+	  {
+	    emit_move_insn (target, CONST0_RTX (mode));
+	    cleared = 1;
+	  }
 
         if (MEM_P (target))
 	  alias = MEM_ALIAS_SET (target);

                 reply	other threads:[~2023-06-13 16:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230613162214.980B23858D38@sourceware.org \
    --to=sayle@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).