public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jason Merrill <jason@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-1954] libcpp: reject codepoints above 0x10FFFF
Date: Mon, 19 Jun 2023 21:20:54 +0000 (GMT)	[thread overview]
Message-ID: <20230619212054.BDE783898513@sourceware.org> (raw)

https://gcc.gnu.org/g:c1dbaa6656acc62c586dad1018f06113cde2d8a4

commit r14-1954-gc1dbaa6656acc62c586dad1018f06113cde2d8a4
Author: Ben Boeckel <ben.boeckel@kitware.com>
Date:   Tue Jun 6 16:50:22 2023 -0400

    libcpp: reject codepoints above 0x10FFFF
    
    Unicode does not support such values because they are unrepresentable in
    UTF-16.
    
    libcpp/
    
            * charset.cc: Reject encodings of codepoints above 0x10FFFF.
            UTF-16 does not support such codepoints and therefore all
            Unicode rejects such values.
    
    Signed-off-by: Ben Boeckel <ben.boeckel@kitware.com>

Diff:
---
 libcpp/charset.cc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libcpp/charset.cc b/libcpp/charset.cc
index d7f323b2cd5..d4f573e365f 100644
--- a/libcpp/charset.cc
+++ b/libcpp/charset.cc
@@ -1886,6 +1886,13 @@ cpp_valid_utf8_p (const char *buffer, size_t num_bytes)
       int err = one_utf8_to_cppchar (&iter, &bytesleft, &cp);
       if (err)
 	return false;
+
+      /* Additionally, Unicode declares that all codepoints above 0010FFFF are
+	 invalid because they cannot be represented in UTF-16.
+
+	 Reject such values.*/
+      if (cp >= UCS_LIMIT)
+	return false;
     }
   /* No problems encountered.  */
   return true;

                 reply	other threads:[~2023-06-19 21:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230619212054.BDE783898513@sourceware.org \
    --to=jason@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).