From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1386) id 4159B3858D1E; Tue, 20 Jun 2023 07:06:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4159B3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687244760; bh=EYLxWgrdeylXJ4YcAy7FJlAXv+ZnBbUPl1zILo//9mo=; h=From:To:Subject:Date:From; b=j8Zdz6WFGNBdA3A6wTtGGbJ+1QN6N/V7l0TbYhMoFzi/c6owAf8JPwitCemOVysXM NYHsHQAM5uBRbRCYnauYgpbFejeWQIJ3HIm+gjukDOQhTOPNelV3ZttU3V1P6VLbZ5 2ufAMgWDAhTp1D2IIKVaim+YWV+6wRp1acAdGsjk= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jan Beulich To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1959] x86: correct and improve "*vec_dupv2di" X-Act-Checkin: gcc X-Git-Author: Jan Beulich X-Git-Refname: refs/heads/master X-Git-Oldrev: 963f87f8a65ec82f503ac4334a3da83b0a8a43b2 X-Git-Newrev: d3a21558fda9da3ce094ea6ecd331ced07e9c6fb Message-Id: <20230620070600.4159B3858D1E@sourceware.org> Date: Tue, 20 Jun 2023 07:06:00 +0000 (GMT) List-Id: https://gcc.gnu.org/g:d3a21558fda9da3ce094ea6ecd331ced07e9c6fb commit r14-1959-gd3a21558fda9da3ce094ea6ecd331ced07e9c6fb Author: Jan Beulich Date: Tue Jun 20 09:05:48 2023 +0200 x86: correct and improve "*vec_dupv2di" The input constraint for the %vmovddup alternative was wrong, as the upper 16 XMM registers require AVX512VL to be used with this insn. To compensate, introduce a new alternative permitting all 32 registers, by broadcasting to the full 512 bits in that case if AVX512VL is not available. gcc/ * config/i386/sse.md (vec_dupv2di): Correct %vmovddup input constraint. Add new AVX512F alternative. gcc/testsuite/ * gcc.target/i386/avx512f-dupv2di.c: New test. Diff: --- gcc/config/i386/sse.md | 28 +++++++++++++++++++------ gcc/testsuite/gcc.target/i386/avx512f-dupv2di.c | 13 ++++++++++++ 2 files changed, 35 insertions(+), 6 deletions(-) diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 87570357db6..b99becba516 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -26162,19 +26162,35 @@ (symbol_ref "true")))]) (define_insn "*vec_dupv2di" - [(set (match_operand:V2DI 0 "register_operand" "=x,v,v,x") + [(set (match_operand:V2DI 0 "register_operand" "=x,v,v,v,x") (vec_duplicate:V2DI - (match_operand:DI 1 "nonimmediate_operand" " 0,Yv,vm,0")))] + (match_operand:DI 1 "nonimmediate_operand" " 0,Yv,vm,Yvm,0")))] "TARGET_SSE" "@ punpcklqdq\t%0, %0 vpunpcklqdq\t{%d1, %0|%0, %d1} + * return TARGET_AVX512VL ? \"vpbroadcastq\t{%1, %0|%0, %1}\" : \"vpbroadcastq\t{%1, %g0|%g0, %1}\"; %vmovddup\t{%1, %0|%0, %1} movlhps\t%0, %0" - [(set_attr "isa" "sse2_noavx,avx,sse3,noavx") - (set_attr "type" "sselog1,sselog1,sselog1,ssemov") - (set_attr "prefix" "orig,maybe_evex,maybe_vex,orig") - (set_attr "mode" "TI,TI,DF,V4SF")]) + [(set_attr "isa" "sse2_noavx,avx,avx512f,sse3,noavx") + (set_attr "type" "sselog1,sselog1,ssemov,sselog1,ssemov") + (set_attr "prefix" "orig,maybe_evex,evex,maybe_vex,orig") + (set (attr "mode") + (cond [(and (eq_attr "alternative" "2") + (match_test "!TARGET_AVX512VL")) + (const_string "XI") + (eq_attr "alternative" "3") + (const_string "DF") + (eq_attr "alternative" "4") + (const_string "V4SF") + ] + (const_string "TI"))) + (set (attr "enabled") + (if_then_else + (eq_attr "alternative" "2") + (symbol_ref "TARGET_AVX512VL + || (TARGET_AVX512F && !TARGET_PREFER_AVX256)") + (const_string "*")))]) (define_insn "avx2_vbroadcasti128_" [(set (match_operand:VI_256 0 "register_operand" "=x,v,v") diff --git a/gcc/testsuite/gcc.target/i386/avx512f-dupv2di.c b/gcc/testsuite/gcc.target/i386/avx512f-dupv2di.c new file mode 100644 index 00000000000..d8d9609a1c4 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/avx512f-dupv2di.c @@ -0,0 +1,13 @@ +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-options "-mavx512f -mno-avx512vl -O2" } */ +/* { dg-final { scan-assembler-not "vmovddup\[^\n\]*%xmm16" } } */ + +typedef long long __attribute__ ((vector_size (16))) v2di; + +v2di bcst (long long ll) +{ + register long long x asm ("xmm16") = ll; + + asm ("" : "+v" (x)); + return (v2di) {x, x}; +}