From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <redi@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2181)
	id DB8653856DC8; Fri, 23 Jun 2023 16:13:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB8653856DC8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1687536798;
	bh=ZWWcvB1fy+/i9Gy3o/TN/JZ2Wv6Vr/wlG7s/ZPVL6h8=;
	h=From:To:Subject:Date:From;
	b=u81VB2ox9aHhVk5OuRl32dq+dNcMgJ9m7SWwhD3VtJf2i3ZpyWsSlFjGJbm6sYy+n
	 tk940srlzeF4DY42dsELFbenRqv3HZtitXKdJpo1JDiYGqr4Un95dQXcqba//D54Aw
	 6RaRUbXigXYxxWr3J7/uK3sFkJtMmLvlClmslUi8=
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r10-11471] libstdc++: Fix std::numeric_limits::lowest() test for
 strict modes
X-Act-Checkin: gcc
X-Git-Author: Jonathan Wakely <jwakely@redhat.com>
X-Git-Refname: refs/heads/releases/gcc-10
X-Git-Oldrev: 291df257830e4ff877c716cfe6430c03677d9606
X-Git-Newrev: f11b715ba891ecc936888cc5d4d6a3fab192b5f6
Message-Id: <20230623161318.DB8653856DC8@sourceware.org>
Date: Fri, 23 Jun 2023 16:13:18 +0000 (GMT)
List-Id: <gcc-cvs.sourceware.org>

https://gcc.gnu.org/g:f11b715ba891ecc936888cc5d4d6a3fab192b5f6

commit r10-11471-gf11b715ba891ecc936888cc5d4d6a3fab192b5f6
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 11 13:28:32 2021 +0100

    libstdc++: Fix std::numeric_limits::lowest() test for strict modes
    
    This test uses std::is_integral to decide whether we are testing an
    integral or floating-point type. But that fails for __int128 because
    is_integral<__int128> is false in strict modes. By using
    numeric_limits::is_integer instead we get the right answer for all types
    that have a numeric_limits specialization.
    
    We can also simplify the test by removing the unnecessary tag
    dispatching.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/18_support/numeric_limits/lowest.cc: Use
            numeric_limits<T>::is_integer instead of is_integral<T>::value.
    
    (cherry picked from commit 45ba5426c129993704a73e6ace4016eaa950d7ee)

Diff:
---
 .../testsuite/18_support/numeric_limits/lowest.cc    | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc b/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc
index 918a4494d60..33015409365 100644
--- a/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc
+++ b/libstdc++-v3/testsuite/18_support/numeric_limits/lowest.cc
@@ -23,30 +23,20 @@
 // 18.2.1.1 template class numeric_limits
 
 #include <limits>
-#include <type_traits>
 #include <testsuite_hooks.h>
 
 template<typename T>
   void
-  do_test(std::true_type)
+  do_test()
   {
     T limits_min = std::numeric_limits<T>::min();
-    VERIFY( std::numeric_limits<T>::lowest() == limits_min );
-  }
-
-template<typename T>
-  void
-  do_test(std::false_type)
-  {
     T limits_max = std::numeric_limits<T>::max();
-    VERIFY( std::numeric_limits<T>::lowest() == -limits_max );
+    if (std::numeric_limits<T>::is_integer)
+      VERIFY( std::numeric_limits<T>::lowest() == limits_min );
+    else
+      VERIFY( std::numeric_limits<T>::lowest() == -limits_max );
   }
 
-template<typename Tp>
-  void
-  do_test()
-  { do_test<Tp>(typename std::is_integral<Tp>::type()); }
-
 void test01()
 {
   do_test<char>();