From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2078) id 807EB3858C2F; Wed, 28 Jun 2023 01:55:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 807EB3858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687917331; bh=iYm5Xd9dYtN8vuSy5wqWCaoAmPFk274jFJXF9PIGRcU=; h=From:To:Subject:Date:From; b=n/Oeib/BqnxYHTYqg5UnF7OG3tjALUIDC/COWqlW3A9TxIkBn+jC7+K6WkoJP7rc3 RD/A9ii7XkmLorPTYxe48WWaTiIptZo2gMelN5qt18Ru/G9DnlPq2M6fai6MZRESl7 nwvz7ENTg+5Kd+KrYCl2P21TcJlpnRR7r6zP5Vz8= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: hongtao Liu To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-7486] Issue a warning for conversion between short and __bf16 under TARGET_AVX512BF16. X-Act-Checkin: gcc X-Git-Author: liuhongt X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: 74ae9709e817534efd86dd42791addb38d130d5d X-Git-Newrev: 59c82332e825d2ef190a79f34180874e5c0ec01b Message-Id: <20230628015531.807EB3858C2F@sourceware.org> Date: Wed, 28 Jun 2023 01:55:31 +0000 (GMT) List-Id: https://gcc.gnu.org/g:59c82332e825d2ef190a79f34180874e5c0ec01b commit r13-7486-g59c82332e825d2ef190a79f34180874e5c0ec01b Author: liuhongt Date: Mon Jun 26 11:46:49 2023 +0800 Issue a warning for conversion between short and __bf16 under TARGET_AVX512BF16. __bfloat16 is redefined from typedef short to real __bf16 since GCC V13. The patch issues an warning for potential silent implicit conversion between __bf16 and short where users may only expect a data movement. To avoid too many false positive, warning is only under TARGET_AVX512BF16. gcc/ChangeLog: * config/i386/i386.cc (ix86_invalid_conversion): New function. (TARGET_INVALID_CONVERSION): Define as ix86_invalid_conversion. gcc/testsuite/ChangeLog: * gcc.target/i386/bf16_short_warn.c: New test. Diff: --- gcc/config/i386/i386.cc | 32 +++++++++++++++++++++++++ gcc/testsuite/gcc.target/i386/bf16_short_warn.c | 17 +++++++++++++ 2 files changed, 49 insertions(+) diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index ad1291d6909..2b0c13a69d6 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -22452,6 +22452,35 @@ x86_emit_floatuns (rtx operands[2]) emit_label (donelab); } + +/* Return the diagnostic message string if conversion from FROMTYPE to + TOTYPE is not allowed, NULL otherwise. + Currently it's used to warn for silent implicit conversion between __bf16 + and short, since __bfloat16 is refined as real __bf16 instead of short + since GCC13. */ + +static const char * +ix86_invalid_conversion (const_tree fromtype, const_tree totype) +{ + if (element_mode (fromtype) != element_mode (totype) + && (TARGET_AVX512BF16 || TARGET_AVXNECONVERT)) + { + /* Warn for silent implicit conversion where user may expect + a bitcast. */ + if ((TYPE_MODE (fromtype) == BFmode + && TYPE_MODE (totype) == HImode) + || (TYPE_MODE (totype) == BFmode + && TYPE_MODE (fromtype) == HImode)) + warning (0, "%<__bfloat16%> is redefined from typedef % " + "to real %<__bf16%> since GCC V13, be careful of " + "implicit conversion between %<__bf16%> and %; " + "a explicit bitcast may be needed here"); + } + + /* Conversion allowed. */ + return NULL; +} + /* Target hook for scalar_mode_supported_p. */ static bool @@ -24713,6 +24742,9 @@ ix86_run_selftests (void) # define TARGET_MERGE_DECL_ATTRIBUTES merge_dllimport_decl_attributes #endif +#undef TARGET_INVALID_CONVERSION +#define TARGET_INVALID_CONVERSION ix86_invalid_conversion + #undef TARGET_COMP_TYPE_ATTRIBUTES #define TARGET_COMP_TYPE_ATTRIBUTES ix86_comp_type_attributes diff --git a/gcc/testsuite/gcc.target/i386/bf16_short_warn.c b/gcc/testsuite/gcc.target/i386/bf16_short_warn.c new file mode 100644 index 00000000000..3e47a815200 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/bf16_short_warn.c @@ -0,0 +1,17 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +#include +typedef struct { +short payload; +} BFloat16; + +__attribute__((target("avx512vl,avx512bf16"))) +BFloat16 tobf16_avx512(float f) +{ + BFloat16 r; + __m128bh m = _mm_cvtneps_pbh(_mm_set_ss(f)); + r.payload = m[0]; /* { dg-warning " be careful of implicit conversion between '__bf16' and 'short'" } */ + return r; +} +