public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Kito Cheng <kito@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-2452] riscv: Simplify output of MEM addresses
Date: Wed, 12 Jul 2023 08:12:59 +0000 (GMT)	[thread overview]
Message-ID: <20230712081259.910353858D20@sourceware.org> (raw)

https://gcc.gnu.org/g:b621883620b127caf20e88e59fa73e666960013e

commit r14-2452-gb621883620b127caf20e88e59fa73e666960013e
Author: Christoph Müllner <christoph.muellner@vrull.eu>
Date:   Thu Apr 27 08:53:29 2023 +0200

    riscv: Simplify output of MEM addresses
    
    We have the following situation for MEM RTX objects:
    * TARGET_PRINT_OPERAND expands to riscv_print_operand()
    * This falls into the default case (unknown or on letter) of the outer
      switch-case-block and the MEM case of the inner switch-case-block and
      calls output_address() in final.cc with XEXP (op, 0) (the address)
    * This calls targetm.asm_out.print_operand_address() which is
      riscv_print_operand_address()
    * riscv_print_operand_address() is targeting the address of a MEM RTX
    * riscv_print_operand_address() calls riscv_print_operand() for the offset
      and directly prints the register if the address is classified as ADDRESS_REG
    * This falls into the default case (unknown or on letter) of the outer
      switch-case-block and the default case of the inner switch-case-block and
      calls output_addr_const().
    
    However, since we know that offset must be a CONST_INT (which will be
    followed by a '(<reg>)' string), there is no need to call
    riscv_print_operand() for the offset.
    Instead we can take the shortcut and use output_addr_const().
    
    This change also brings the code in riscv_print_operand_address()
    in line with the other cases, where output_addr_const() is used
    to print offsets.
    
    Tested with GCC regression test suite and SPEC intrate.
    
    Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
    
    gcc/ChangeLog:
    
            * config/riscv/riscv.cc (riscv_print_operand_address): Use
            output_addr_const rather than riscv_print_operand.

Diff:
---
 gcc/config/riscv/riscv.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 38d8eb2fcf5..4d6e70b95f7 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -4801,7 +4801,7 @@ riscv_print_operand_address (FILE *file, machine_mode mode ATTRIBUTE_UNUSED, rtx
     switch (addr.type)
       {
       case ADDRESS_REG:
-	riscv_print_operand (file, addr.offset, 0);
+	output_addr_const (file, riscv_strip_unspec_address (addr.offset));
 	fprintf (file, "(%s)", reg_names[REGNO (addr.reg)]);
 	return;

                 reply	other threads:[~2023-07-12  8:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712081259.910353858D20@sourceware.org \
    --to=kito@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).