public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jeff Law <law@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] DSE: Add LEN_MASK_STORE analysis into DSE and fix LEN_STORE Date: Fri, 14 Jul 2023 02:50:12 +0000 (GMT) [thread overview] Message-ID: <20230714025012.9ACC13857C66@sourceware.org> (raw) https://gcc.gnu.org/g:a139bad18d2d8791c44c342eaabac7619c9b14c7 commit a139bad18d2d8791c44c342eaabac7619c9b14c7 Author: Ju-Zhe Zhong <juzhe.zhong@rivai.ai> Date: Mon Jun 26 15:43:42 2023 +0800 DSE: Add LEN_MASK_STORE analysis into DSE and fix LEN_STORE Hi, Richi. This patch is adding LEN_MASK_STORE into DSE. My understanding is LEN_MASK_STORE is predicated by mask and len. No matter len is constant or not, the ao_ref should be the same as MASK_STORE. Wheras for LEN_STORE, when len is constant, we use (len - bias), otherwise, it's the same as MASK_STORE/LEN_MASK_STORE. Not sure whether I am on the same page with you, feel free to correct me. Thanks. gcc/ChangeLog: * tree-ssa-dse.cc (initialize_ao_ref_for_dse): Add LEN_MASK_STORE and fix LEN_STORE. (dse_optimize_stmt): Add LEN_MASK_STORE. Diff: --- gcc/tree-ssa-dse.cc | 47 +++++++++++++++++++++++++++++++---------------- 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/gcc/tree-ssa-dse.cc b/gcc/tree-ssa-dse.cc index eabe8ba4522..95ace407ddb 100644 --- a/gcc/tree-ssa-dse.cc +++ b/gcc/tree-ssa-dse.cc @@ -48,6 +48,7 @@ along with GCC; see the file COPYING3. If not see #include "tree-ssa-loop-niter.h" #include "cfgloop.h" #include "tree-data-ref.h" +#include "internal-fn.h" /* This file implements dead store elimination. @@ -157,23 +158,36 @@ initialize_ao_ref_for_dse (gimple *stmt, ao_ref *write, bool may_def_ok = false) switch (gimple_call_internal_fn (stmt)) { case IFN_LEN_STORE: - ao_ref_init_from_ptr_and_size - (write, gimple_call_arg (stmt, 0), - int_const_binop (MINUS_EXPR, - gimple_call_arg (stmt, 2), - gimple_call_arg (stmt, 4))); - return true; case IFN_MASK_STORE: - /* We cannot initialize a must-def ao_ref (in all cases) but we - can provide a may-def variant. */ - if (may_def_ok) - { - ao_ref_init_from_ptr_and_size - (write, gimple_call_arg (stmt, 0), - TYPE_SIZE_UNIT (TREE_TYPE (gimple_call_arg (stmt, 3)))); - return true; - } - break; + case IFN_LEN_MASK_STORE: + { + int stored_value_index + = internal_fn_stored_value_index (gimple_call_internal_fn (stmt)); + if (gimple_call_internal_fn (stmt) == IFN_LEN_STORE) + { + tree len = gimple_call_arg (stmt, 2); + tree bias = gimple_call_arg (stmt, 4); + if (tree_fits_uhwi_p (len)) + { + ao_ref_init_from_ptr_and_size (write, + gimple_call_arg (stmt, 0), + int_const_binop (MINUS_EXPR, + len, bias)); + return true; + } + } + /* We cannot initialize a must-def ao_ref (in all cases) but we + can provide a may-def variant. */ + if (may_def_ok) + { + ao_ref_init_from_ptr_and_size ( + write, gimple_call_arg (stmt, 0), + TYPE_SIZE_UNIT ( + TREE_TYPE (gimple_call_arg (stmt, stored_value_index)))); + return true; + } + break; + } default:; } } @@ -1483,6 +1497,7 @@ dse_optimize_stmt (function *fun, gimple_stmt_iterator *gsi, sbitmap live_bytes) { case IFN_LEN_STORE: case IFN_MASK_STORE: + case IFN_LEN_MASK_STORE: { enum dse_store_status store_status; store_status = dse_classify_store (&ref, stmt, false, live_bytes);
next reply other threads:[~2023-07-14 2:50 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-14 2:50 Jeff Law [this message] -- strict thread matches above, loose matches on Subject: below -- 2023-06-26 20:57 Jeff Law
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230714025012.9ACC13857C66@sourceware.org \ --to=law@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).