public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-2958] [committed][RISC-V] Remove errant hunk of code
@ 2023-08-03 15:03 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2023-08-03 15:03 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:d61efa3cd3378be38738bfb5139925d1505c1325

commit r14-2958-gd61efa3cd3378be38738bfb5139925d1505c1325
Author: Jeff Law <jeffreyalaw@gmail.com>
Date:   Thu Aug 3 10:57:23 2023 -0400

    [committed][RISC-V] Remove errant hunk of code
    
    I'm using this hunk locally to more thoroughly exercise the zicond paths
    due to inaccuracies elsewhere in the costing model.  It was never
    supposed to be part of the costing commit though.  And as we've seen
    it's causing problems with the vector bits.
    
    While my testing isn't complete, this hunk was never supposed to be
    pushed and it's causing problems.  So I'm just ripping it out.
    
    There's a bigger TODO in this space WRT a top-to-bottom evaluation of
    the costing on RISC-V.  I'm still formulating what that evaluation is
    going to look like, so don't hold your breath waiting on it.
    
    Pushed to the trunk.
    
    gcc/
    
            * config/riscv/riscv.cc (riscv_rtx_costs): Remove errant hunk from
            recent commit.

Diff:
---
 gcc/config/riscv/riscv.cc | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 9e75450aa97..d8fab68dbb4 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -2913,16 +2913,6 @@ riscv_rtx_costs (rtx x, machine_mode mode, int outer_code, int opno ATTRIBUTE_UN
 	}
       return false;
 
-    case SET:
-      /* A simple SET with a register destination takes its cost solely from
-	 the SET_SRC operand.  */
-      if (outer_code == INSN && REG_P (SET_DEST (x)))
-	{
-	  *total = riscv_rtx_costs (SET_SRC (x), mode, SET, opno, total, speed);
-	  return true;
-	}
-      return false;
-
     default:
       return false;
     }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-03 15:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 15:03 [gcc r14-2958] [committed][RISC-V] Remove errant hunk of code Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).