From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1984) id 7823D385771C; Fri, 4 Aug 2023 12:50:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7823D385771C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1691153428; bh=JCW4YVxu0QZ7VDUJHMlko9iZo9q2fVz2RbxzJ77fDE8=; h=From:To:Subject:Date:From; b=uHKDDxS5qluFS4KJGwhIsUrjTlnkmtI+2B5uIQ0av201e/RkrFkJmE4T53i/pVe9Q TtWbVC4q9hV8OyYtUwMuB+pCyHcvfh+EAFfkZ6SOFTVJGb0ztlmiVAt8S9xS6kNPlV 9wFGYIL6/7tOyUoJhOmF7jDbkiaN4zdrFK/rGUSE= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Tamar Christina To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-2990] gensupport: Don't segfault on empty attrs list X-Act-Checkin: gcc X-Git-Author: Tamar Christina X-Git-Refname: refs/heads/master X-Git-Oldrev: 8787b195f014883a2d2454faf2001303dfefef8c X-Git-Newrev: 6b80071a4d05c9535d3bb26cddaed0895a414f59 Message-Id: <20230804125028.7823D385771C@sourceware.org> Date: Fri, 4 Aug 2023 12:50:28 +0000 (GMT) List-Id: https://gcc.gnu.org/g:6b80071a4d05c9535d3bb26cddaed0895a414f59 commit r14-2990-g6b80071a4d05c9535d3bb26cddaed0895a414f59 Author: Tamar Christina Date: Fri Aug 4 13:48:56 2023 +0100 gensupport: Don't segfault on empty attrs list Currently we segfault when len == 0 for an attribute list. essentially [cons: =0, 1, 2, 3; attrs: ] segfaults but should be equivalent to [cons: =0, 1, 2, 3] and [cons: =0, 1, 2, 3; attrs:]. This fixes it by just returning early and leaving it to the validators whether this should error out or not. gcc/ChangeLog: * gensupport.cc (conlist): Support length 0 attribute. Diff: --- gcc/gensupport.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc index 959d1d9c83c..b2feb03363a 100644 --- a/gcc/gensupport.cc +++ b/gcc/gensupport.cc @@ -620,7 +620,7 @@ public: conlist (const char *ns, unsigned int len, bool numeric) { /* Trim leading whitespaces. */ - while (ISBLANK (*ns)) + while (len > 0 && ISBLANK (*ns)) { ns++; len--; @@ -632,7 +632,7 @@ public: break; /* Parse off any modifiers. */ - while (!ISALNUM (*ns)) + while (len > 0 && !ISALNUM (*ns)) { con += *(ns++); len--;