public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-3033] Improve -fopt-info-vec for basic-block vectorization Date: Mon, 7 Aug 2023 13:18:04 +0000 (GMT) [thread overview] Message-ID: <20230807131804.CEA353858D28@sourceware.org> (raw) https://gcc.gnu.org/g:aa63c20420db78ca77ec243af02c7591b88d3b89 commit r14-3033-gaa63c20420db78ca77ec243af02c7591b88d3b89 Author: Richard Biener <rguenther@suse.de> Date: Mon Aug 7 13:53:59 2023 +0200 Improve -fopt-info-vec for basic-block vectorization We currently dump notes like flow_lam.f:65:72: optimized: basic block part vectorized using 32 byte vectors flow_lam.f:65:72: optimized: basic block part vectorized using 32 byte vectors flow_lam.f:65:72: optimized: basic block part vectorized using 32 byte vectors flow_lam.f:65:72: optimized: basic block part vectorized using 32 byte vectors .. repeating the same location for multiple instances because we clobber vect_location during BB vectorization. The following avoids this, improving things to flow_lam.f:15:72: optimized: basic block part vectorized using 32 byte vectors flow_lam.f:16:72: optimized: basic block part vectorized using 32 byte vectors flow_lam.f:17:72: optimized: basic block part vectorized using 32 byte vectors flow_lam.f:18:72: optimized: basic block part vectorized using 32 byte vectors ... * tree-vect-slp.cc (vect_slp_region): Save/restore vect_location around dumping code. Diff: --- gcc/tree-vect-slp.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index a1b153035e1..eab3dcd40ec 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -7496,6 +7496,7 @@ vect_slp_region (vec<basic_block> bbs, vec<data_reference_p> datarefs, if (instance->subgraph_entries.is_empty ()) continue; + dump_user_location_t saved_vect_location = vect_location; vect_location = instance->location (); if (!unlimited_cost_model (NULL) && !vect_bb_vectorization_profitable_p @@ -7505,9 +7506,11 @@ vect_slp_region (vec<basic_block> bbs, vec<data_reference_p> datarefs, dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, "not vectorized: vectorization is not " "profitable.\n"); + vect_location = saved_vect_location; continue; } + vect_location = saved_vect_location; if (!dbg_cnt (vect_slp)) continue; @@ -7557,6 +7560,9 @@ vect_slp_region (vec<basic_block> bbs, vec<data_reference_p> datarefs, "using SLP\n"); vectorized = true; + dump_user_location_t saved_vect_location = vect_location; + vect_location = instance->location (); + vect_schedule_slp (bb_vinfo, instance->subgraph_entries); unsigned HOST_WIDE_INT bytes; @@ -7572,6 +7578,8 @@ vect_slp_region (vec<basic_block> bbs, vec<data_reference_p> datarefs, "basic block part vectorized using " "variable length vectors\n"); } + + vect_location = saved_vect_location; } } else
reply other threads:[~2023-08-07 13:18 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230807131804.CEA353858D28@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).