public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Fix one ICE for vect test vect-multitypes-5
@ 2023-09-11 13:33 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2023-09-11 13:33 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:a11c14d56e501c41dd77addaee0c26a0e26fe514

commit a11c14d56e501c41dd77addaee0c26a0e26fe514
Author: Pan Li <pan2.li@intel.com>
Date:   Tue Aug 29 18:41:30 2023 +0800

    RISC-V: Fix one ICE for vect test vect-multitypes-5
    
    There will be one ICE when build vect-multitypes-5.c similar as below:
    
    riscv64-unknown-elf-gcc -O3 \
      -march=rv64imafdcv -mabi=lp64d -mcmodel=medlow \
      -fdiagnostics-plain-output -flto -ffat-lto-objects \
      --param riscv-autovec-preference=scalable -Wno-psabi \
      -ftree-vectorize -fno-tree-loop-distribute-patterns \
      -fno-vect-cost-model -fno-common -O2 -fdump-tree-vect-details \
      gcc/testsuite/gcc.dg/vect/vect-multitypes-5.c -o test.elf -lm
    
    The below RTL is not well handled in riscv_legitimize_const_move, and
    then fall through to the default pass. Then the
    default force_const_mem will NULL_RTX, and will have ICE when operating
    one the NULL_RTX.
    
    (const:DI
      (plus:DI
        (symbol_ref:DI ("ic") [flags 0x2] <var_decl 0x7fe57740be10 ic>)
        (const_poly_int:DI [16, 16])))
    
    This patch would like to take care of this rtl in riscv_legitimize_const_move.
    
    Signed-off-by: Pan Li <pan2.li@intel.com>
    Co-Authored-By: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
    
    gcc/ChangeLog:
    
            * config/riscv/riscv.cc (riscv_legitimize_poly_move): New declaration.
            (riscv_legitimize_const_move): Handle ref plus const poly.
    
    (cherry picked from commit d16af3ebea84749ac673db29a4124d2dc7cd369e)

Diff:
---
 gcc/config/riscv/riscv.cc | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 1d6e278ea90a..bab6ed70b2d2 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -366,6 +366,7 @@ static const struct riscv_tune_param optimize_size_tune_info = {
 
 static tree riscv_handle_fndecl_attribute (tree *, tree, tree, int, bool *);
 static tree riscv_handle_type_attribute (tree *, tree, tree, int, bool *);
+static void riscv_legitimize_poly_move (machine_mode, rtx, rtx, rtx);
 
 /* Defining target-specific uses of __attribute__.  */
 static const struct attribute_spec riscv_attribute_table[] =
@@ -2118,6 +2119,28 @@ riscv_legitimize_const_move (machine_mode mode, rtx dest, rtx src)
       return;
     }
 
+  /* Handle below format.
+     (const:DI
+       (plus:DI
+	 (symbol_ref:DI ("ic") [flags 0x2] <var_decl 0x7fe57740be10 ic>) <- op_0
+	 (const_poly_int:DI [16, 16]) // <- op_1
+     ))
+   */
+  rtx src_op_0 = XEXP (src, 0);
+
+  if (GET_CODE (src) == CONST && GET_CODE (src_op_0) == PLUS
+    && CONST_POLY_INT_P (XEXP (src_op_0, 1)))
+    {
+      rtx dest_tmp = gen_reg_rtx (mode);
+      rtx tmp = gen_reg_rtx (mode);
+
+      riscv_emit_move (dest, XEXP (src_op_0, 0));
+      riscv_legitimize_poly_move (mode, dest_tmp, tmp, XEXP (src_op_0, 1));
+
+      emit_insn (gen_rtx_SET (dest, gen_rtx_PLUS (mode, dest, dest_tmp)));
+      return;
+    }
+
   src = force_const_mem (mode, src);
 
   /* When using explicit relocs, constant pool references are sometimes

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-11 13:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 13:33 [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Fix one ICE for vect test vect-multitypes-5 Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).