public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Expand fixed-vlmax/vls vector permutation in targethook
@ 2023-09-11 13:39 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2023-09-11 13:39 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:1df8bef088851c3593695279f0aab25b4f6cf57e

commit 1df8bef088851c3593695279f0aab25b4f6cf57e
Author: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Date:   Sun Sep 10 10:33:04 2023 +0800

    RISC-V: Expand fixed-vlmax/vls vector permutation in targethook
    
    When debugging FAIL: gcc.dg/pr92301.c execution test.
    Realize a vls vector permutation situation failed to vectorize since early return false:
    
    -  /* For constant size indices, we dont't need to handle it here.
    -     Just leave it to vec_perm<mode>.  */
    -  if (d->perm.length ().is_constant ())
    -    return false;
    
    To avoid more potential failed vectorization case. Now expand it in targethook.
    
    gcc/ChangeLog:
    
            * config/riscv/riscv-v.cc (shuffle_generic_patterns): Expand
            fixed-vlmax/vls vector permutation.
    
    (cherry picked from commit 108779056eb4b56e715a094fac48a699d2dc91b3)

Diff:
---
 gcc/config/riscv/riscv-v.cc | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
index 8a548f5d1a27..847bc2487c84 100644
--- a/gcc/config/riscv/riscv-v.cc
+++ b/gcc/config/riscv/riscv-v.cc
@@ -2793,14 +2793,9 @@ shuffle_generic_patterns (struct expand_vec_perm_d *d)
   if (!pow2p_hwi (d->perm.encoding().npatterns ()))
     return false;
 
-  /* For constant size indices, we dont't need to handle it here.
-     Just leave it to vec_perm<mode>.  */
-  if (d->perm.length ().is_constant ())
-    return false;
-
   /* Permuting two SEW8 variable-length vectors need vrgatherei16.vv.
      Otherwise, it could overflow the index range.  */
-  if (GET_MODE_INNER (d->vmode) == QImode
+  if (!nunits.is_constant () && GET_MODE_INNER (d->vmode) == QImode
       && !get_vector_mode (HImode, nunits).exists (&sel_mode))
     return false;
 
@@ -2809,7 +2804,12 @@ shuffle_generic_patterns (struct expand_vec_perm_d *d)
     return true;
 
   rtx sel = vec_perm_indices_to_rtx (sel_mode, d->perm);
-  expand_vec_perm (d->target, d->op0, d->op1, force_reg (sel_mode, sel));
+  /* 'mov<mode>' generte interleave vector.  */
+  if (!nunits.is_constant ())
+    sel = force_reg (sel_mode, sel);
+  /* Some FIXED-VLMAX/VLS vector permutation situations call targethook
+     instead of expand vec_perm<mode>, we handle it directly.  */
+  expand_vec_perm (d->target, d->op0, d->op1, sel);
   return true;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-11 13:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 13:39 [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Expand fixed-vlmax/vls vector permutation in targethook Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).