public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-10987] aarch64: Avoid a use of callee_offset
Date: Tue, 12 Sep 2023 15:20:24 +0000 (GMT)	[thread overview]
Message-ID: <20230912152024.645483858C33@sourceware.org> (raw)

https://gcc.gnu.org/g:a2a57f7ec7912e77eb26919545807d90065584ff

commit r11-10987-ga2a57f7ec7912e77eb26919545807d90065584ff
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Sep 12 16:19:44 2023 +0100

    aarch64: Avoid a use of callee_offset
    
    When we emit the frame chain, i.e. when we reach Here in this statement
    of aarch64_expand_prologue:
    
      if (emit_frame_chain)
        {
          // Here
          ...
        }
    
    the stack is in one of two states:
    
    - We've allocated up to the frame chain, but no more.
    
    - We've allocated the whole frame, and the frame chain is within easy
      reach of the new SP.
    
    The offset of the frame chain from the current SP is available
    in aarch64_frame as callee_offset.  It is also available as the
    chain_offset local variable, where the latter is calculated from other
    data.  (However, chain_offset is not always equal to callee_offset when
    !emit_frame_chain, so chain_offset isn't redundant.)
    
    In c600df9a4060da3c6121ff4d0b93f179eafd69d1 I switched to using
    chain_offset for the initialisation of the hard frame pointer:
    
           aarch64_add_offset (Pmode, hard_frame_pointer_rtx,
    -                         stack_pointer_rtx, callee_offset,
    +                         stack_pointer_rtx, chain_offset,
                              tmp1_rtx, tmp0_rtx, frame_pointer_needed);
    
    But the later REG_CFA_ADJUST_CFA handling still used callee_offset.
    
    I think the difference is harmless, but it's more logical for the
    CFA note to be in sync, and it's more convenient for later patches
    if it uses chain_offset.
    
    gcc/
            * config/aarch64/aarch64.c (aarch64_expand_prologue): Use
            chain_offset rather than callee_offset.

Diff:
---
 gcc/config/aarch64/aarch64.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 77c1d1300a5c..6bc026bd08f9 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -8901,7 +8901,6 @@ aarch64_expand_prologue (void)
   poly_int64 initial_adjust = frame.initial_adjust;
   HOST_WIDE_INT callee_adjust = frame.callee_adjust;
   poly_int64 final_adjust = frame.final_adjust;
-  poly_int64 callee_offset = frame.callee_offset;
   poly_int64 sve_callee_adjust = frame.sve_callee_adjust;
   poly_int64 below_hard_fp_saved_regs_size
     = frame.below_hard_fp_saved_regs_size;
@@ -9010,8 +9009,7 @@ aarch64_expand_prologue (void)
 	     implicit.  */
 	  if (!find_reg_note (insn, REG_CFA_ADJUST_CFA, NULL_RTX))
 	    {
-	      rtx src = plus_constant (Pmode, stack_pointer_rtx,
-				       callee_offset);
+	      rtx src = plus_constant (Pmode, stack_pointer_rtx, chain_offset);
 	      add_reg_note (insn, REG_CFA_ADJUST_CFA,
 			    gen_rtx_SET (hard_frame_pointer_rtx, src));
 	    }

                 reply	other threads:[~2023-09-12 15:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912152024.645483858C33@sourceware.org \
    --to=rsandifo@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).