public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-4080] Remove xfail from gcc.dg/tree-ssa/20040204-1.c
Date: Sun, 17 Sep 2023 21:47:36 +0000 (GMT)	[thread overview]
Message-ID: <20230917214736.C304A3858D32@sourceware.org> (raw)

https://gcc.gnu.org/g:51f1287e0a207c60329b64e6085f39766ee8be2a

commit r14-4080-g51f1287e0a207c60329b64e6085f39766ee8be2a
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sun Sep 17 21:41:01 2023 +0000

    Remove xfail from gcc.dg/tree-ssa/20040204-1.c
    
    So the xfail was there because at one point the difference
    from having logical-op-non-short-circuit set to 1 or 0 made a
    difference in being able to optimizing a conditional way.
    This has not been true for over 10 years in this case so
    instead of keeping on adding to the xfail list, removing it
    is the right thing to do.
    
    Committed as obvious after a test on x86_64-linux-gnu.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.dg/tree-ssa/20040204-1.c: Remove xfail.

Diff:
---
 gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c b/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c
index b9f8fd21ac9..aa9f68b8b42 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c
@@ -29,8 +29,4 @@ void test55 (int x, int y)
 
 /* There should be not link_error calls, if there is any the
    optimization has failed */
-/* ??? Ug.  This one may or may not fail based on how fold decides
-   that the && should be emitted (based on BRANCH_COST).  Fix this
-   by teaching dom to look through && and register all components
-   as true.  */
-/* { dg-final { scan-tree-dump-times "link_error" 0 "optimized" { xfail { ! "alpha*-*-* arm*-*-* aarch64*-*-* powerpc*-*-* cris-*-* hppa*-*-* i?86-*-* mmix-*-* mips*-*-* m68k*-*-* moxie-*-* nds32*-*-* s390*-*-* sh*-*-* sparc*-*-* visium-*-* x86_64-*-* riscv*-*-* or1k*-*-* msp430-*-* pru*-*-* nvptx*-*-*" } } } } */
+/* { dg-final { scan-tree-dump-times "link_error" 0 "optimized" } } */

                 reply	other threads:[~2023-09-17 21:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230917214736.C304A3858D32@sourceware.org \
    --to=pinskia@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).