public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Law <law@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Fix VSETVL PASS fusion bug
Date: Mon, 18 Sep 2023 18:28:17 +0000 (GMT)	[thread overview]
Message-ID: <20230918182817.233603857713@sourceware.org> (raw)

https://gcc.gnu.org/g:ebc06ff84738455d1c9da3d5f82f91bd9203c5b5

commit ebc06ff84738455d1c9da3d5f82f91bd9203c5b5
Author: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Date:   Mon Sep 18 19:08:25 2023 +0800

    RISC-V: Fix VSETVL PASS fusion bug
    
    There is an obvious fusion bug that is exposed by more VLS patterns support.
    After more VLS modes support, it cause following FAILs:
    FAIL: gcc.target/riscv/rvv/autovec/reduc/reduc_run-2.c execution test
    FAIL: gcc.target/riscv/rvv/autovec/reduc/reduc_run-2.c execution test
    FAIL: gcc.target/riscv/rvv/autovec/reduc/reduc_run-2.c execution test
    FAIL: gcc.target/riscv/rvv/autovec/reduc/reduc_run-2.c execution test
    
    Demand 1: SEW = 64, LMUL = 1, RATIO = 64, demand SEW, demand GE_SEW.
    Demand 2: SEW = 64, LMUL = 2, RATIO = 32, demand SEW, demand GE_SEW, demand RATIO.
    
    Before this patch:
    merge demand: SEW = 64, LMUL = 1, RATIO = 32, demand SEW, demand LMUL, demand GE_SEW.
    It's obvious incorrect of merge LMUL which should be new LMUL = (demand 2 RATIO * greatest SEW) = M2
    
    gcc/ChangeLog:
    
            * config/riscv/riscv-vsetvl.cc (vlmul_for_greatest_sew_second_ratio): New function.
            * config/riscv/riscv-vsetvl.def (DEF_SEW_LMUL_FUSE_RULE): Fix bug.
    
    (cherry picked from commit 8fbc0871da26fac1668ba939f4492876794734ac)

Diff:
---
 gcc/config/riscv/riscv-vsetvl.cc  | 8 ++++++++
 gcc/config/riscv/riscv-vsetvl.def | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc
index 5f031c18df5..df980b6770e 100644
--- a/gcc/config/riscv/riscv-vsetvl.cc
+++ b/gcc/config/riscv/riscv-vsetvl.cc
@@ -1308,6 +1308,14 @@ vlmul_for_first_sew_second_ratio (const vector_insn_info &info1,
   return calculate_vlmul (info1.get_sew (), info2.get_ratio ());
 }
 
+static vlmul_type
+vlmul_for_greatest_sew_second_ratio (const vector_insn_info &info1,
+				     const vector_insn_info &info2)
+{
+  return calculate_vlmul (MAX (info1.get_sew (), info2.get_sew ()),
+			  info2.get_ratio ());
+}
+
 static unsigned
 ratio_for_second_sew_first_vlmul (const vector_insn_info &info1,
 				  const vector_insn_info &info2)
diff --git a/gcc/config/riscv/riscv-vsetvl.def b/gcc/config/riscv/riscv-vsetvl.def
index 7289c01efcf..709cc4ee0df 100644
--- a/gcc/config/riscv/riscv-vsetvl.def
+++ b/gcc/config/riscv/riscv-vsetvl.def
@@ -329,8 +329,8 @@ DEF_SEW_LMUL_FUSE_RULE (/*SEW*/ DEMAND_TRUE, /*LMUL*/ DEMAND_FALSE,
 			/*NEW_DEMAND_SEW*/ true,
 			/*NEW_DEMAND_LMUL*/ false,
 			/*NEW_DEMAND_RATIO*/ true,
-			/*NEW_DEMAND_GE_SEW*/ true, greatest_sew, first_vlmul,
-			second_ratio)
+			/*NEW_DEMAND_GE_SEW*/ true, greatest_sew,
+			vlmul_for_greatest_sew_second_ratio, second_ratio)
 DEF_SEW_LMUL_FUSE_RULE (/*SEW*/ DEMAND_TRUE, /*LMUL*/ DEMAND_FALSE,
 			/*RATIO*/ DEMAND_ANY, /*GE_SEW*/ DEMAND_TRUE,
 			/*SEW*/ DEMAND_FALSE, /*LMUL*/ DEMAND_TRUE,

                 reply	other threads:[~2023-09-18 18:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918182817.233603857713@sourceware.org \
    --to=law@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).