[gcc r13-7877] ada: Call idiomatic routine in Expand_Simple_Function_Return

[gcc r13-7877] ada: Call idiomatic routine in Expand_Simple_Function_Return

[Eric Botcazou]

https://gcc.gnu.org/g:6a8e6f7b072263b56e3e4fe897eb1df696030020

commit r13-7877-g6a8e6f7b072263b56e3e4fe897eb1df696030020
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Sat Apr 8 12:43:54 2023 +0200

    ada: Call idiomatic routine in Expand_Simple_Function_Return
    
    In the primary stack case, Insert_Actions is invoked when the expression is
    being rewritten, whereas Insert_List_Before_And_Analyze is invoked in the
    secondary stack case.  The former is idiomatic, the latter is not.
    
    gcc/ada/
    
            * exp_ch6.adb (Expand_Simple_Function_Return): Call Insert_Actions
            consistently when rewriting the expression.

Diff:
---
 gcc/ada/exp_ch6.adb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/ada/exp_ch6.adb b/gcc/ada/exp_ch6.adb
index aee67d4546b..81362ad571c 100644
--- a/gcc/ada/exp_ch6.adb
+++ b/gcc/ada/exp_ch6.adb
@@ -6830,7 +6830,7 @@ package body Exp_Ch6 is
 
                Temp := Make_Temporary (Loc, 'R', Alloc_Node);
 
-               Insert_List_Before_And_Analyze (N, New_List (
+               Insert_Actions (Exp, New_List (
                  Make_Full_Type_Declaration (Loc,
                    Defining_Identifier => Acc_Typ,
                    Type_Definition     =>