public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/rguenth/heads/vect-force-slp)] Properly reject SLP gather with builtin decl
Date: Fri,  6 Oct 2023 07:07:27 +0000 (GMT)	[thread overview]
Message-ID: <20231006070727.DCFB43858000@sourceware.org> (raw)

https://gcc.gnu.org/g:5fb7c61b94f9d83e31e26fa7f2f7f2279d2748ef

commit 5fb7c61b94f9d83e31e26fa7f2f7f2279d2748ef
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Sep 29 14:34:33 2023 +0200

    Properly reject SLP gather with builtin decl
    
    The builtin decl path for gather load vectorization doesn't implement
    SLP (PR111131).  Check that instead of ICEing.
    
            * tree-vect-stmts.cc (vectorizable_load): Reject SLP gather
            with builtin decl vectorization.

Diff:
---
 gcc/tree-vect-stmts.cc | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index 4b0852dead1..a4a912474a1 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -9770,6 +9770,14 @@ vectorizable_load (vec_info *vinfo,
 	}
     }
 
+  if (memory_access_type == VMAT_GATHER_SCATTER && gs_info.decl && slp)
+    {
+      if (dump_enabled_p ())
+	dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
+			 "unsupported SLP gather.\n");
+      return false;
+    }
+
   bool costing_p = !vec_stmt;
 
   if (costing_p) /* transformation not required.  */

             reply	other threads:[~2023-10-06  7:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06  7:07 Richard Biener [this message]
2023-10-16 12:50 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006070727.DCFB43858000@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).