public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/rguenth/heads/vect-force-slp)] Add FIXME note regarding gcc.dg/vect/pr60276.c runfail with single-lane SLP
Date: Fri,  6 Oct 2023 07:07:38 +0000 (GMT)	[thread overview]
Message-ID: <20231006070738.106F83858D3C@sourceware.org> (raw)

https://gcc.gnu.org/g:d281c06dff379be55f32a77ca112d8f4994197d5

commit d281c06dff379be55f32a77ca112d8f4994197d5
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Oct 4 14:34:18 2023 +0200

    Add FIXME note regarding gcc.dg/vect/pr60276.c runfail with single-lane SLP
    
            * tree-vect-stmts.cc (vectorizable_load): Add FIXME to
            PR60276 fix.

Diff:
---
 gcc/tree-vect-stmts.cc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index a4a912474a1..f29ee9f19bf 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -9628,6 +9628,11 @@ vectorizable_load (vec_info *vinfo,
 
   /* Invalidate assumptions made by dependence analysis when vectorization
      on the unrolled body effectively re-orders stmts.  */
+  /* ???  This fails to trigger with single-lane SLP, gcc.dg/vect/pr60276.c,
+     but simply removing the ncopies > 1 conditional here (and below) will
+     cause FAILs of gcc.dg/vect/no-vfa-vect-depend-3.c and
+     gcc.dg/vect/tsvc/vect-tsvc-s3251.c.  The original fix (for PR60276)
+     needs to be re-thought.  */
   if (ncopies > 1
       && STMT_VINFO_MIN_NEG_DIST (stmt_info) != 0
       && maybe_gt (LOOP_VINFO_VECT_FACTOR (loop_vinfo),

             reply	other threads:[~2023-10-06  7:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06  7:07 Richard Biener [this message]
2023-10-16 12:50 Richard Biener
2023-10-19 13:29 Richard Biener
2023-11-02 13:59 Richard Biener
2023-11-09 13:03 Richard Biener
2024-02-23  7:31 Richard Biener
2024-05-13 14:27 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006070738.106F83858D3C@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).