From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1873) id 75EB03858436; Sat, 14 Oct 2023 12:22:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75EB03858436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697286169; bh=ZMxkYZfm3hsde7naemo6Nhg0OU1Q5P23j9wOVdYlpdM=; h=From:To:Subject:Date:From; b=gdiSgif1KfDZxqA0qX+VRSESnTSbpKWx1iroLOx6v2O/BI/kJnWv20GW4rUsDatw/ j8bQuFtPaONlgSBIAodgBIAZbtyPYb08kYszf61HwIX7ycyfZUh6jKhf4l3bX7qiw5 bbvi2q4OPtnLsGvSmB08MwoTzgLdmeDs3xeggOYw= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Iain Buclaw To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-4639] Fix ICE in set_cell_span, at text-art/table.cc:148 with D front-end and -fanalyzer X-Act-Checkin: gcc X-Git-Author: Iain Buclaw X-Git-Refname: refs/heads/master X-Git-Oldrev: 06d8aee3aaa7928321acc6f7752aa5dee9661bf3 X-Git-Newrev: 578afbc751d122b55196a23fe75a17e1b4e9bd0c Message-Id: <20231014122249.75EB03858436@sourceware.org> Date: Sat, 14 Oct 2023 12:22:49 +0000 (GMT) List-Id: https://gcc.gnu.org/g:578afbc751d122b55196a23fe75a17e1b4e9bd0c commit r14-4639-g578afbc751d122b55196a23fe75a17e1b4e9bd0c Author: Iain Buclaw Date: Sat Oct 14 02:19:41 2023 +0200 Fix ICE in set_cell_span, at text-art/table.cc:148 with D front-end and -fanalyzer The internal error in analyzer turned out to be caused by a subtly invalid tree representation of STRING_CSTs in the D front-end, fixed by including the terminating NULL as part of the TREE_STRING_POINTER. When adding a first analyzer test for D, it flagged up another subtle mismatch in one assignment in the module support routines as well, fixed by generating the correct field type for the compiler-generated struct. PR d/111537 gcc/d/ChangeLog: * expr.cc (ExprVisitor::visit (StringExp *)): Include null terminator in STRING_CST string. * modules.cc (get_compiler_dso_type): Generate ModuleInfo** type for the minfo fields. gcc/testsuite/ChangeLog: * gdc.dg/analyzer/analyzer.exp: New test. * gdc.dg/analyzer/pr111537.d: New test. Diff: --- gcc/d/expr.cc | 6 ++-- gcc/d/modules.cc | 9 +++--- gcc/testsuite/gdc.dg/analyzer/analyzer.exp | 51 ++++++++++++++++++++++++++++++ gcc/testsuite/gdc.dg/analyzer/pr111537.d | 7 ++++ 4 files changed, 66 insertions(+), 7 deletions(-) diff --git a/gcc/d/expr.cc b/gcc/d/expr.cc index 7038655bc94..551d004c241 100644 --- a/gcc/d/expr.cc +++ b/gcc/d/expr.cc @@ -2535,13 +2535,13 @@ public: { /* Copy the string contents to a null terminated string. */ dinteger_t length = (e->len * e->sz); - char *string = XALLOCAVEC (char, length + 1); + char *string = XALLOCAVEC (char, length + e->sz); + memset (string, 0, length + e->sz); if (length > 0) memcpy (string, e->string, length); - string[length] = '\0'; /* String value and type includes the null terminator. */ - tree value = build_string (length, string); + tree value = build_string (length + e->sz, string); TREE_TYPE (value) = make_array_type (tb->nextOf (), length + 1); value = build_address (value); diff --git a/gcc/d/modules.cc b/gcc/d/modules.cc index f2180d30546..8d6c8f0f9ad 100644 --- a/gcc/d/modules.cc +++ b/gcc/d/modules.cc @@ -277,12 +277,13 @@ get_compiler_dso_type (void) DECL_CHAIN (field) = fields; fields = field; - field = create_field_decl (build_pointer_type (get_moduleinfo_type ()), - NULL, 1, 1); + tree moduleinfo_ptr_ptr_type = + build_pointer_type (build_pointer_type (get_moduleinfo_type ())); + + field = create_field_decl (moduleinfo_ptr_ptr_type, NULL, 1, 1); DECL_CHAIN (field) = fields; fields = field; - field = create_field_decl (build_pointer_type (get_moduleinfo_type ()), - NULL, 1, 1); + field = create_field_decl (moduleinfo_ptr_ptr_type, NULL, 1, 1); DECL_CHAIN (field) = fields; fields = field; diff --git a/gcc/testsuite/gdc.dg/analyzer/analyzer.exp b/gcc/testsuite/gdc.dg/analyzer/analyzer.exp new file mode 100644 index 00000000000..7b82b8e0cd1 --- /dev/null +++ b/gcc/testsuite/gdc.dg/analyzer/analyzer.exp @@ -0,0 +1,51 @@ +# Copyright (C) 2023 Free Software Foundation, Inc. + +# This file is part of GCC. +# +# GCC is free software; you can redistribute it and/or modify it under +# the terms of the GNU General Public License as published by the Free +# Software Foundation; either version 3, or (at your option) any later +# version. +# +# GCC is distributed in the hope that it will be useful, but WITHOUT ANY +# WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# for more details. +# +# You should have received a copy of the GNU General Public License +# along with GCC; see the file COPYING3. If not see +# . + +# GCC testsuite that uses the `dg.exp' driver. + +# Load support procs. +load_lib gdc-dg.exp + +# If the analyzer has not been enabled, bail. +if { ![check_effective_target_analyzer] } { + return +} + +global DEFAULT_DFLAGS +if [info exists DEFAULT_DFLAGS] then { + set save_default_dflags $DEFAULT_DFLAGS +} + +# If a testcase doesn't have special options, use these. +set DEFAULT_DFLAGS "-fanalyzer -Wanalyzer-too-complex -fanalyzer-call-summaries" + +# Initialize `dg'. +dg-init + +# Main loop. +gdc-dg-runtest [lsort \ + [glob -nocomplain $srcdir/$subdir/*.d ] ] "" $DEFAULT_DFLAGS + +# All done. +dg-finish + +if [info exists save_default_dflags] { + set DEFAULT_DFLAGS $save_default_dflags +} else { + unset DEFAULT_DFLAGS +} diff --git a/gcc/testsuite/gdc.dg/analyzer/pr111537.d b/gcc/testsuite/gdc.dg/analyzer/pr111537.d new file mode 100644 index 00000000000..e50b05a3f79 --- /dev/null +++ b/gcc/testsuite/gdc.dg/analyzer/pr111537.d @@ -0,0 +1,7 @@ +// { dg-do compile } +import core.stdc.string; +void main() +{ + char[5] arr; + strcpy(arr.ptr, "hello world"); // { dg-warning "stack-based buffer overflow" } +}