From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id EBCEC3858C35; Tue, 17 Oct 2023 16:04:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBCEC3858C35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697558657; bh=J0awptfAq9lmJ85wSKvTuCA0soaEW4rN0ldikItXGwI=; h=From:To:Subject:Date:From; b=A9LTScZz8MuJ+6vnPTK36q1cIb5yKxHl80T9ZWSoU9IoxggbMPksk0XvTEInph6Ky Iyfm9VTgpzGpTVd3hm20pNq4MisI1DhdQKy6WrDVU8VpsKYrbRBLiDXlUe5oQl7ktN UzTwnzYd+qerrSJ5p4sOQj9ZbcWg5xlAFC1r9QlI= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-4686] MATCH: [PR111432] Simplify `a & (x | CST)` to a when we know that (a & ~CST) == 0 X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: da65efe433f20984bab93335d8f994a6987847e6 X-Git-Newrev: b18d1cabe2f9cccc0cad697e1e0bfd2abebb85f9 Message-Id: <20231017160417.EBCEC3858C35@sourceware.org> Date: Tue, 17 Oct 2023 16:04:17 +0000 (GMT) List-Id: https://gcc.gnu.org/g:b18d1cabe2f9cccc0cad697e1e0bfd2abebb85f9 commit r14-4686-gb18d1cabe2f9cccc0cad697e1e0bfd2abebb85f9 Author: Andrew Pinski Date: Fri Oct 13 13:27:18 2023 -0700 MATCH: [PR111432] Simplify `a & (x | CST)` to a when we know that (a & ~CST) == 0 This adds the simplification `a & (x | CST)` to a when we know that `(a & ~CST) == 0`. In a similar fashion as `a & CST` is handle. I looked into handling `a | (x & CST)` but that I don't see any decent simplifications happening. OK? Bootstrapped and tested on x86_linux-gnu with no regressions. PR tree-optimization/111432 gcc/ChangeLog: * match.pd (`a & (x | CST)`): New pattern. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/bitops-7.c: New test. Diff: --- gcc/match.pd | 8 ++++++++ gcc/testsuite/gcc.dg/tree-ssa/bitops-7.c | 24 ++++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/gcc/match.pd b/gcc/match.pd index dbd554e2e7c1..067328a2a16b 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -1550,6 +1550,14 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (if (INTEGRAL_TYPE_P (TREE_TYPE (@0)) && wi::bit_and_not (get_nonzero_bits (@0), wi::to_wide (@1)) == 0) @0)) + +/* `a & (x | CST)` -> a if we know that (a & ~CST) == 0 */ +(simplify + (bit_and:c SSA_NAME@0 (bit_ior @1 INTEGER_CST@2)) + (if (INTEGRAL_TYPE_P (TREE_TYPE (@0)) + && wi::bit_and_not (get_nonzero_bits (@0), wi::to_wide (@2)) == 0) + @0)) + /* x | C -> C if we know that x & ~C == 0. */ (simplify (bit_ior SSA_NAME@0 INTEGER_CST@1) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/bitops-7.c b/gcc/testsuite/gcc.dg/tree-ssa/bitops-7.c new file mode 100644 index 000000000000..7fb18db3a110 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/bitops-7.c @@ -0,0 +1,24 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized-raw" } */ +/* PR tree-optimization/111432 */ + +int +foo3(int c, int bb) +{ + if ((bb & ~3)!=0) __builtin_unreachable(); + return (bb & (c|3)); +} + +int +foo_bool(int c, _Bool bb) +{ + return (bb & (c|7)); +} + +/* Both of these functions should be able to remove the `IOR` and `AND` + as the only bits that are non-zero for bb is set on the other side + of the `AND`. + */ + +/* { dg-final { scan-tree-dump-not "bit_ior_expr, " "optimized" } } */ +/* { dg-final { scan-tree-dump-not "bit_and_expr, " "optimized" } } */