From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 5F5553858425; Tue, 17 Oct 2023 17:06:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F5553858425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697562402; bh=2Ss1Tc01nMGZM2Fq2qwEqDcdmyrI9F51QAZp2kj0pL4=; h=From:To:Subject:Date:From; b=B6kOvWiwHBz8Vc2N4CcxFmA5ByR6VtUQ2TFPwYPQBGvcjATfYNUrkt4AELWOi8+4D RuZGPiCZxTBamCtmSkPsesp77LlKqNcIaPDJfC2jVkp8B0KUH7uT6ekGIEsEPfKvnT fvdLHoZXd9j9rZtyL8VD89Wsq6925uzAXGJ8Ewt4= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-4688] Fortran: out of bounds access with nested implied-do IO [PR111837] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/master X-Git-Oldrev: 43c2f85f52c8400b7204e24400c52c3173c50735 X-Git-Newrev: 5ac63ec5da2e93226457bea4dbb3a4f78d5d82c2 Message-Id: <20231017170642.5F5553858425@sourceware.org> Date: Tue, 17 Oct 2023 17:06:42 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5ac63ec5da2e93226457bea4dbb3a4f78d5d82c2 commit r14-4688-g5ac63ec5da2e93226457bea4dbb3a4f78d5d82c2 Author: Harald Anlauf Date: Mon Oct 16 21:02:20 2023 +0200 Fortran: out of bounds access with nested implied-do IO [PR111837] gcc/fortran/ChangeLog: PR fortran/111837 * frontend-passes.cc (traverse_io_block): Dependency check of loop nest shall be triangular, not banded. gcc/testsuite/ChangeLog: PR fortran/111837 * gfortran.dg/implied_do_io_8.f90: New test. Diff: --- gcc/fortran/frontend-passes.cc | 2 +- gcc/testsuite/gfortran.dg/implied_do_io_8.f90 | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/frontend-passes.cc b/gcc/fortran/frontend-passes.cc index 136a292807d3..536884b13f09 100644 --- a/gcc/fortran/frontend-passes.cc +++ b/gcc/fortran/frontend-passes.cc @@ -1326,7 +1326,7 @@ traverse_io_block (gfc_code *code, bool *has_reached, gfc_code *prev) if (iters[i]) { gfc_expr *var = iters[i]->var; - for (int j = i - 1; j < i; j++) + for (int j = 0; j < i; j++) { if (iters[j] && (var_in_expr (var, iters[j]->start) diff --git a/gcc/testsuite/gfortran.dg/implied_do_io_8.f90 b/gcc/testsuite/gfortran.dg/implied_do_io_8.f90 new file mode 100644 index 000000000000..c66a0f6fde66 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/implied_do_io_8.f90 @@ -0,0 +1,18 @@ +! { dg-do run } +! { dg-additional-options "-fcheck=bounds" } +! PR fortran/111837 - out of bounds access with front-end optimization + +program implied_do_bug + implicit none + integer :: i,j,k + real :: arr(1,1,1) + integer :: ni(1) + ni(1) = 1 + arr = 1 + write(*,*) (((arr(i,j,k), i=1,ni(k)), k=1,1), j=1,1) + write(*,*) (((arr(i,j,k), i=1,ni(k)), j=1,1), k=1,1) + write(*,*) (((arr(k,i,j), i=1,ni(k)), k=1,1), j=1,1) + write(*,*) (((arr(k,i,j), i=1,ni(k)), j=1,1), k=1,1) + write(*,*) (((arr(j,k,i), i=1,ni(k)), k=1,1), j=1,1) + write(*,*) (((arr(j,k,i), i=1,ni(k)), j=1,1), k=1,1) +end