public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-4722] cse: Workaround GCC < 5 bug in cse_insn [PR111852]
Date: Wed, 18 Oct 2023 15:07:12 +0000 (GMT)	[thread overview]
Message-ID: <20231018150712.57ACC3858D33@sourceware.org> (raw)

https://gcc.gnu.org/g:bc4bd69faf986326f6b0fd0400cdd6871577afd1

commit r14-4722-gbc4bd69faf986326f6b0fd0400cdd6871577afd1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Oct 18 17:01:26 2023 +0200

    cse: Workaround GCC < 5 bug in cse_insn [PR111852]
    
    Before the r5-3834 commit for PR63362, GCC 4.8-4.9 refuses to compile
    cse.cc which contains a variable with rtx_def type, because rtx_def
    contains a union with poly_uint16 element.  poly_int template has
    defaulted default constructor and a variadic template constructor which
    could have empty parameter pack. GCC < 5 treated it as non-trivially
    constructible class and deleted rtunion and rtx_def default constructors.
    
    For the cse_insn purposes, all we need is a variable with size and alignment
    of rtx_def, not necessarily rtx_def itself, which we then memset to 0 and
    fill in like rtx is normally allocated from heap, so this patch for
    GCC_VERSION < 5000 uses an unsigned char array of the right size/alignment.
    
    2023-10-18  Jakub Jelinek  <jakub@redhat.com>
    
            PR bootstrap/111852
            * cse.cc (cse_insn): Add workaround for GCC 4.8-4.9, instead of
            using rtx_def type for memory_extend_buf, use unsigned char
            arrayy with size of rtx_def and its alignment.

Diff:
---
 gcc/cse.cc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gcc/cse.cc b/gcc/cse.cc
index c46870059e6c..f9603fdfd437 100644
--- a/gcc/cse.cc
+++ b/gcc/cse.cc
@@ -4951,8 +4951,15 @@ cse_insn (rtx_insn *insn)
 	  && is_a <scalar_int_mode> (mode, &int_mode)
 	  && (extend_op = load_extend_op (int_mode)) != UNKNOWN)
 	{
+#if GCC_VERSION >= 5000
 	  struct rtx_def memory_extend_buf;
 	  rtx memory_extend_rtx = &memory_extend_buf;
+#else
+	  /* Workaround GCC < 5 bug, fixed in r5-3834 as part of PR63362
+	     fix.  */
+	  alignas (rtx_def) unsigned char memory_extended_buf[sizeof (rtx_def)];
+	  rtx memory_extend_rtx = (rtx) &memory_extended_buf[0];
+#endif
 
 	  /* Set what we are trying to extend and the operation it might
 	     have been extended with.  */

                 reply	other threads:[~2023-10-18 15:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018150712.57ACC3858D33@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).