From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id F26623858D1E; Thu, 19 Oct 2023 16:50:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F26623858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697734220; bh=ZYDXH3ZxZIa9ay/qzLA8WSVNvYNkOmw7FVyuAHKwrDY=; h=From:To:Subject:Date:From; b=RjjRuHJb1kgMSs+nM29mFKm4ZOi1+x1qc3UbXwJek/zV86ZkBHaiC0ga0SsIOofYb QL5wOhFVjEm2NN5wpPzqp7Vhle+gmbb6q9FuAMjh6yUgvI92ERj2I1XNar75Awqusf NV71oEasRcfWMx64luZHkwlAi2kYru3ZPJ/aZUTE= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-4758] c: Don't warn about converting NULL to different sso endian [PR104822] X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 00e7c49fa04a3766e4726322b427621a74b78c71 X-Git-Newrev: 9f33e4c50ee92a2053f52e5eb8f205afa54d4cb0 Message-Id: <20231019165020.F26623858D1E@sourceware.org> Date: Thu, 19 Oct 2023 16:50:20 +0000 (GMT) List-Id: https://gcc.gnu.org/g:9f33e4c50ee92a2053f52e5eb8f205afa54d4cb0 commit r14-4758-g9f33e4c50ee92a2053f52e5eb8f205afa54d4cb0 Author: Andrew Pinski Date: Wed Oct 18 20:49:05 2023 -0700 c: Don't warn about converting NULL to different sso endian [PR104822] In a similar way we don't warn about NULL pointer constant conversion to a different named address we should not warn to a different sso endian either. This adds the simple check. Bootstrapped and tested on x86_64-linux-gnu with no regressions. PR c/104822 gcc/c/ChangeLog: * c-typeck.cc (convert_for_assignment): Check for null pointer before warning about an incompatible scalar storage order. gcc/testsuite/ChangeLog: * gcc.dg/sso-18.c: New test. * gcc.dg/sso-19.c: New test. Diff: --- gcc/c/c-typeck.cc | 1 + gcc/testsuite/gcc.dg/sso-18.c | 16 ++++++++++++++++ gcc/testsuite/gcc.dg/sso-19.c | 17 +++++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index 6e044b4afbc9..f39dc71d5932 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -7449,6 +7449,7 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type, /* See if the pointers point to incompatible scalar storage orders. */ if (warn_scalar_storage_order + && !null_pointer_constant_p (rhs) && (AGGREGATE_TYPE_P (ttl) && TYPE_REVERSE_STORAGE_ORDER (ttl)) != (AGGREGATE_TYPE_P (ttr) && TYPE_REVERSE_STORAGE_ORDER (ttr))) { diff --git a/gcc/testsuite/gcc.dg/sso-18.c b/gcc/testsuite/gcc.dg/sso-18.c new file mode 100644 index 000000000000..799a0c858f20 --- /dev/null +++ b/gcc/testsuite/gcc.dg/sso-18.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* PR c/104822 */ + +#include + +struct Sb { + int i; +} __attribute__((scalar_storage_order("big-endian"))); +struct Sl { + int i; +} __attribute__((scalar_storage_order("little-endian"))); + +/* Neither of these should warn about incompatible scalar storage order + as NULL pointers are compatiable with both endian. */ +struct Sb *pb = NULL; /* { dg-bogus "" } */ +struct Sl *pl = NULL; /* { dg-bogus "" } */ diff --git a/gcc/testsuite/gcc.dg/sso-19.c b/gcc/testsuite/gcc.dg/sso-19.c new file mode 100644 index 000000000000..50f7b40c6086 --- /dev/null +++ b/gcc/testsuite/gcc.dg/sso-19.c @@ -0,0 +1,17 @@ +/* { dg-do compile } */ +/* { dg-options "-std=c2x" } */ +/* PR c/104822 */ + +#include + +struct Sb { + int i; +} __attribute__((scalar_storage_order("big-endian"))); +struct Sl { + int i; +} __attribute__((scalar_storage_order("little-endian"))); + +/* Neither of these should warn about incompatible scalar storage order + as NULL pointers are compatiable with both endian. */ +struct Sb *pb = nullptr; /* { dg-bogus "" } */ +struct Sl *pl = nullptr; /* { dg-bogus "" } */