public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/rguenth/heads/vect-force-slp)] Avoid ICEing with SLP scatter
Date: Thu,  2 Nov 2023 13:59:40 +0000 (GMT)	[thread overview]
Message-ID: <20231102135940.C2A723858430@sourceware.org> (raw)

https://gcc.gnu.org/g:4ce8bd68e45be33d0598f3c117bcd2d41bd69635

commit 4ce8bd68e45be33d0598f3c117bcd2d41bd69635
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Sep 29 13:39:07 2023 +0200

    Avoid ICEing with SLP scatter
    
    When we SLP discover scatters vectorizable_store will ICE instead
    of rejecting it.  See PR111133 for the missing support.
    
            * tree-vect-stmts.cc (vectorizable_store): Reject SLP or
            grouped scatters.

Diff:
---
 gcc/tree-vect-stmts.cc | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index 2a73e914bdf4..509e76b9f7b2 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -8344,6 +8344,15 @@ vectorizable_store (vec_info *vinfo,
 	return false;
     }
 
+  /* PR111133.  */
+  if (memory_access_type == VMAT_GATHER_SCATTER && (slp || grouped_store))
+    {
+      if (dump_enabled_p ())
+	dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
+			 "unsupported grouped or SLP scatter.\n");
+      return false;
+    }
+
   bool costing_p = !vec_stmt;
   if (costing_p) /* transformation not required.  */
     {

             reply	other threads:[~2023-11-02 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 13:59 Richard Biener [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-19 13:29 Richard Biener
2023-10-16 12:49 Richard Biener
2023-10-06  7:07 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102135940.C2A723858430@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).