public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/rguenth/heads/vect-force-slp)] Guard SLP optimize latch edge discovery
Date: Thu,  9 Nov 2023 13:03:13 +0000 (GMT)	[thread overview]
Message-ID: <20231109130313.4DAB23860C2B@sourceware.org> (raw)

https://gcc.gnu.org/g:a44166ac67ecfb06cb15a39f9f9626538809588a

commit a44166ac67ecfb06cb15a39f9f9626538809588a
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Sep 29 12:57:59 2023 +0200

    Guard SLP optimize latch edge discovery
    
    When inserting additional VEC_PERM nodes it seems we can run
    is_cfg_latch_edge but given there's eventually no representative
    we should avoid ICEing on it.
    
            * tree-vect-slp.cc (vect_optimize_slp_pass::is_cfg_latch_edge):
            VER_PERM node use is never the destination of a latch.

Diff:
---
 gcc/tree-vect-slp.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
index 30ed123d100..4c7ad976963 100644
--- a/gcc/tree-vect-slp.cc
+++ b/gcc/tree-vect-slp.cc
@@ -4306,7 +4306,8 @@ vect_optimize_slp_pass::is_cfg_latch_edge (graph_edge *ud)
   slp_tree use = m_vertices[ud->src].node;
   slp_tree def = m_vertices[ud->dest].node;
   if (SLP_TREE_DEF_TYPE (use) != vect_internal_def
-      || SLP_TREE_DEF_TYPE (def) != vect_internal_def)
+      || SLP_TREE_DEF_TYPE (def) != vect_internal_def
+      || SLP_TREE_CODE (use) == VEC_PERM_EXPR)
     return false;
 
   stmt_vec_info use_rep = vect_orig_stmt (SLP_TREE_REPRESENTATIVE (use));

             reply	other threads:[~2023-11-09 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 13:03 Richard Biener [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-23  7:31 Richard Biener
2023-11-02 13:59 Richard Biener
2023-10-19 13:28 Richard Biener
2023-10-16 12:49 Richard Biener
2023-10-06  7:07 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109130313.4DAB23860C2B@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).