public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] testsuite: scev: expect fail on ilp32
Date: Sat, 18 Nov 2023 05:36:19 +0000 (GMT)	[thread overview]
Message-ID: <20231118053619.269793858D3C@sourceware.org> (raw)

https://gcc.gnu.org/g:cccc80091fdc6c9a2b7c67b17577d91eb832cce2

commit cccc80091fdc6c9a2b7c67b17577d91eb832cce2
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Sat Nov 18 02:11:43 2023 -0300

    testsuite: scev: expect fail on ilp32
    
    I've recently patched scev-3.c and scev-5.c because it only passed by
    accident on ia32.  It also fails on some (but not all) arm-eabi
    variants.  It seems hard to characterize the conditions in which the
    optimization is supposed to pass, but expecting them to fail on ilp32
    targets, though probably a little excessive and possibly noisy, is not
    quite as alarming as getting a fail in test reports, so I propose
    changing the xfail marker from ia32 to ilp32.
    
    I'm also proposing to add a similar marker to scev-4.c.  Though it
    doesn't appear to be failing for me, I've got reports that suggest it
    still does for others, and it certainly did for us as well.
    
    
    for  gcc/testsuite/ChangeLog
    
            * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets,
            though some of these do pass.
            * gcc.dg/tree-ssa/scev-4.c: Likewise.
            * gcc.dg/tree-ssa/scev-5.c: Likewise.

Diff:
---
 gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 3 ++-
 gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 3 ++-
 gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
index ac8c8d4519e..beea9aed9fe 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
index 57cb0213402..a97f75f81f6 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
@@ -45,4 +45,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
index c911a929886..08f4260403c 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */

             reply	other threads:[~2023-11-18  5:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  5:36 Alexandre Oliva [this message]
2023-11-19  4:44 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231118053619.269793858D3C@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).