From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2140) id 269793858D3C; Sat, 18 Nov 2023 05:36:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 269793858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1700285779; bh=oMjekR9PqvrdwlJe4kcY6GHSrRyAZcD5ybsxDZYYjmE=; h=From:To:Subject:Date:From; b=chTFrfnXonCmQvnd8YhRD16OnFtDy9rnCE0PRf0He4RO1LKYTD3HJ29wBSR//nwo+ ec0ycUVfwAjA1WxyGSJgiwvKVVWoW3tQABhky5ehac4fxApwF2pw7PEHx3CWeYQOHz Rez4sdcy/kiYgOFxm8w2MKgas04tEESxObBrNMO4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandre Oliva To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] testsuite: scev: expect fail on ilp32 X-Act-Checkin: gcc X-Git-Author: Alexandre Oliva X-Git-Refname: refs/users/aoliva/heads/testme X-Git-Oldrev: 444347c11ba38a114d3a21c271265723418d72dd X-Git-Newrev: cccc80091fdc6c9a2b7c67b17577d91eb832cce2 Message-Id: <20231118053619.269793858D3C@sourceware.org> Date: Sat, 18 Nov 2023 05:36:19 +0000 (GMT) List-Id: https://gcc.gnu.org/g:cccc80091fdc6c9a2b7c67b17577d91eb832cce2 commit cccc80091fdc6c9a2b7c67b17577d91eb832cce2 Author: Alexandre Oliva Date: Sat Nov 18 02:11:43 2023 -0300 testsuite: scev: expect fail on ilp32 I've recently patched scev-3.c and scev-5.c because it only passed by accident on ia32. It also fails on some (but not all) arm-eabi variants. It seems hard to characterize the conditions in which the optimization is supposed to pass, but expecting them to fail on ilp32 targets, though probably a little excessive and possibly noisy, is not quite as alarming as getting a fail in test reports, so I propose changing the xfail marker from ia32 to ilp32. I'm also proposing to add a similar marker to scev-4.c. Though it doesn't appear to be failing for me, I've got reports that suggest it still does for others, and it certainly did for us as well. for gcc/testsuite/ChangeLog * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets, though some of these do pass. * gcc.dg/tree-ssa/scev-4.c: Likewise. * gcc.dg/tree-ssa/scev-5.c: Likewise. Diff: --- gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 3 ++- gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 3 ++- gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c index ac8c8d4519e..beea9aed9fe 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c @@ -40,4 +40,5 @@ __BB(6): } -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ +/* Not all 32-bit systems fail this, but several do. */ +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c index 57cb0213402..a97f75f81f6 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c @@ -45,4 +45,5 @@ __BB(6): } -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */ +/* Not all 32-bit systems fail this, but several do. */ +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c index c911a929886..08f4260403c 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c @@ -40,4 +40,5 @@ __BB(6): } -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ +/* Not all 32-bit systems fail this, but several do. */ +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */