public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/aoliva/heads/testme)] testsuite: scev: expect fail on ilp32
@ 2023-11-19  4:44 Alexandre Oliva
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Oliva @ 2023-11-19  4:44 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:c59549ebc11809ad3f5bf0fe9eed98267a7c16d2

commit c59549ebc11809ad3f5bf0fe9eed98267a7c16d2
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Sat Nov 18 02:11:43 2023 -0300

    testsuite: scev: expect fail on ilp32
    
    I've recently patched scev-3.c and scev-5.c because it only passed by
    accident on ia32.  It also fails on some (but not all) arm-eabi
    variants.  It seems hard to characterize the conditions in which the
    optimization is supposed to pass, but expecting them to fail on ilp32
    targets, though probably a little excessive and possibly noisy, is not
    quite as alarming as getting a fail in test reports, so I propose
    changing the xfail marker from ia32 to ilp32.
    
    I'm also proposing to add a similar marker to scev-4.c.  Though it
    doesn't appear to be failing for me, I've got reports that suggest it
    still does for others, and it certainly did for us as well.
    
    
    for  gcc/testsuite/ChangeLog
    
            * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets,
            though some of these do pass.
            * gcc.dg/tree-ssa/scev-4.c: Likewise.
            * gcc.dg/tree-ssa/scev-5.c: Likewise.

Diff:
---
 gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 3 ++-
 gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 3 ++-
 gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
index ac8c8d4519e..beea9aed9fe 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
index 57cb0213402..a97f75f81f6 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
@@ -45,4 +45,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
index c911a929886..08f4260403c 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] testsuite: scev: expect fail on ilp32
@ 2023-11-18  5:36 Alexandre Oliva
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Oliva @ 2023-11-18  5:36 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:cccc80091fdc6c9a2b7c67b17577d91eb832cce2

commit cccc80091fdc6c9a2b7c67b17577d91eb832cce2
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Sat Nov 18 02:11:43 2023 -0300

    testsuite: scev: expect fail on ilp32
    
    I've recently patched scev-3.c and scev-5.c because it only passed by
    accident on ia32.  It also fails on some (but not all) arm-eabi
    variants.  It seems hard to characterize the conditions in which the
    optimization is supposed to pass, but expecting them to fail on ilp32
    targets, though probably a little excessive and possibly noisy, is not
    quite as alarming as getting a fail in test reports, so I propose
    changing the xfail marker from ia32 to ilp32.
    
    I'm also proposing to add a similar marker to scev-4.c.  Though it
    doesn't appear to be failing for me, I've got reports that suggest it
    still does for others, and it certainly did for us as well.
    
    
    for  gcc/testsuite/ChangeLog
    
            * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets,
            though some of these do pass.
            * gcc.dg/tree-ssa/scev-4.c: Likewise.
            * gcc.dg/tree-ssa/scev-5.c: Likewise.

Diff:
---
 gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 3 ++-
 gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 3 ++-
 gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
index ac8c8d4519e..beea9aed9fe 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
index 57cb0213402..a97f75f81f6 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
@@ -45,4 +45,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
index c911a929886..08f4260403c 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-19  4:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-19  4:44 [gcc(refs/users/aoliva/heads/testme)] testsuite: scev: expect fail on ilp32 Alexandre Oliva
  -- strict thread matches above, loose matches on Subject: below --
2023-11-18  5:36 Alexandre Oliva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).