public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] testsuite: arm: fix arm_movt cut&pasto
Date: Sun, 19 Nov 2023 06:31:26 +0000 (GMT)	[thread overview]
Message-ID: <20231119063126.9ADD7385842B@sourceware.org> (raw)

https://gcc.gnu.org/g:47c3446bd87091babe7a03e61f5857a846ea61b9

commit 47c3446bd87091babe7a03e61f5857a846ea61b9
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Sun Nov 19 02:41:48 2023 -0300

    testsuite: arm: fix arm_movt cut&pasto
    
    I got spurious fails of tests that required arm_thumb1_movt_ok on a
    target cpu that did not support movt.  Looking into it, I found the
    arm_movt property to have been cut&pasted into various procs that
    checked for different properties.  They shouldn't share the same test
    results cache entry, so I'm changing their prop names.
    
    
    for  gcc/testsuite/ChangeLog
    
            * lib/target-supports.exp
            (check_effective_target_arm_thumb1_cbz_ok): Fix prop name
            cut&pasto.
            (check_effective_target_arm_arch_v6t2_hw_ok): Likewise.

Diff:
---
 gcc/testsuite/lib/target-supports.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 240a3815d38..e3519207d0e 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5610,7 +5610,7 @@ proc check_effective_target_arm_thumb1_movt_ok {} {
 
 proc check_effective_target_arm_thumb1_cbz_ok {} {
     if [check_effective_target_arm_thumb1_ok] {
-	return [check_no_compiler_messages arm_movt object {
+	return [check_no_compiler_messages arm_cbz object {
 	    int
 	    foo (void)
 	    {
@@ -5627,7 +5627,7 @@ proc check_effective_target_arm_thumb1_cbz_ok {} {
 
 proc check_effective_target_arm_arch_v6t2_hw_ok {} {
     if [check_effective_target_arm_thumb1_ok] {
-	return [check_no_compiler_messages arm_movt object {
+	return [check_no_compiler_messages arm_v6t2_hw object {
 	    int
 	    main (void)
 	    {

             reply	other threads:[~2023-11-19  6:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-19  6:31 Alexandre Oliva [this message]
2023-11-19  7:02 Alexandre Oliva
2023-11-19  8:11 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231119063126.9ADD7385842B@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).