public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] c++: mark short-enums as packed
Date: Thu, 23 Nov 2023 11:46:18 +0000 (GMT) [thread overview]
Message-ID: <20231123114618.4EEB8385B51C@sourceware.org> (raw)
https://gcc.gnu.org/g:0d1b4440f1f62aedcc9fe206f1f6845509cecdef
commit 0d1b4440f1f62aedcc9fe206f1f6845509cecdef
Author: Alexandre Oliva <oliva@adacore.com>
Date: Sun Nov 19 01:22:31 2023 -0300
c++: mark short-enums as packed
Unlike C, C++ doesn't mark enums shortened by -fshort-enums as packed.
This makes for undesirable warning differences between C and C++,
e.g. c-c++-common/analyzer/null-deref-pr108251-smp_fetch_ssl_fc_has_early*.c
triggers a warning about a type cast from a pointer to enum that, when
packed, might not be sufficiently aligned.
This change is not enough for that warning to trigger. The tree
expression generated by the C++ front-end is also a little too
complicated for us get to the base pointer. A separate patch takes
care of that.
for gcc/cp/ChangeLog
* decl.cc (finish_enum_value_list): Set TYPE_PACKED if
use_short_enum, and propagate it to variants.
Diff:
---
gcc/cp/decl.cc | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc
index 4b3791c4606..4200a007d9a 100644
--- a/gcc/cp/decl.cc
+++ b/gcc/cp/decl.cc
@@ -16893,6 +16893,12 @@ finish_enum_value_list (tree enumtype)
/* If -fstrict-enums, still constrain TYPE_MIN/MAX_VALUE. */
if (flag_strict_enums)
set_min_and_max_values_for_integral_type (enumtype, precision, sgn);
+
+ if (use_short_enum)
+ {
+ TYPE_PACKED (enumtype) = use_short_enum;
+ fixup_attribute_variants (enumtype);
+ }
}
else
underlying_type = ENUM_UNDERLYING_TYPE (enumtype);
next reply other threads:[~2023-11-23 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 11:46 Alexandre Oliva [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-19 8:11 Alexandre Oliva
2023-11-19 6:31 Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123114618.4EEB8385B51C@sourceware.org \
--to=aoliva@gcc.gnu.org \
--cc=gcc-cvs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).