From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1448) id 524E63857C67; Thu, 23 Nov 2023 14:32:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 524E63857C67 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1700749960; bh=HPVsm7fhzrjcg310hVlzU1G5//JSCrh2LBzhBxcucUA=; h=From:To:Subject:Date:From; b=aRan1yLFamakchvHGqGZv+UBqmaRbMEZo4FiD54mSNO9OyHEApI6IDagl6lJac00J jzgh8FYobV5ks8bX4Q6/CW54yjAmUfRpoI1izEsvGRv3bkRdiR+l/NIug8jQfEYRdc ghZWbr8ZM0yP8s/0hQ1rDuIUjeSauy080vpqEpPg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andreas Krebbel To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-5780] s390: Fix ICE in testcase pr89233 X-Act-Checkin: gcc X-Git-Author: Juergen Christ X-Git-Refname: refs/heads/master X-Git-Oldrev: 746344dd53807d840c29f52adba10d0ab093bd3d X-Git-Newrev: 2add85eeb01cb3d5db841a3d271bd7c37a77dba1 Message-Id: <20231123143240.524E63857C67@sourceware.org> Date: Thu, 23 Nov 2023 14:32:40 +0000 (GMT) List-Id: https://gcc.gnu.org/g:2add85eeb01cb3d5db841a3d271bd7c37a77dba1 commit r14-5780-g2add85eeb01cb3d5db841a3d271bd7c37a77dba1 Author: Juergen Christ Date: Mon Nov 20 09:12:18 2023 +0100 s390: Fix ICE in testcase pr89233 When using GNU vector extensions, an access outside of the vector size caused an ICE on s390. Fix this by aligning with the vec_extract builtin, i.e., computing constant index modulo number of lanes. Fixes testcase gcc.target/s390/pr89233.c. gcc/ChangeLog: * config/s390/vector.md: (*vec_extract) Fix. Signed-off-by: Juergen Christ Diff: --- gcc/config/s390/vector.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md index 4f4c9d96b3d..626ec118229 100644 --- a/gcc/config/s390/vector.md +++ b/gcc/config/s390/vector.md @@ -531,12 +531,14 @@ (match_operand:V 1 "nonmemory_operand" "v,v") (parallel [(match_operand:SI 2 "nonmemory_operand" "an,I")])))] - "TARGET_VX - && (!CONST_INT_P (operands[2]) - || UINTVAL (operands[2]) < GET_MODE_NUNITS (mode))" - "@ - vlgv\t%0,%v1,%Y2 - vste\t%v1,%0,%2" + "TARGET_VX" + { + if (CONST_INT_P (operands[2])) + operands[2] = GEN_INT (UINTVAL (operands[2]) & (GET_MODE_NUNITS (mode) - 1)); + if (which_alternative == 0) + return "vlgv\t%0,%v1,%Y2"; + return "vste\t%v1,%0,%2"; + } [(set_attr "op_type" "VRS,VRX")]) ; vlgvb, vlgvh, vlgvf, vlgvg