From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1363) id 69C94386186C; Thu, 23 Nov 2023 15:18:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69C94386186C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1700752706; bh=B5EnMN/u5EG2chDulc54g+RkHptsm/WtbJ3SMFWw0v0=; h=From:To:Subject:Date:From; b=a2qnt8SzSF2vOX9cPjmfpLiSvQ9GPrs2yzJSRS31GNzMuoS22TZpnokFSAZK0zpmq 1740KefqEj7/QLZcvSF+hHIaSjFyhkGg+Dp5lgG9OMqL36gqLi366x0i7z2SzEDpoM pNt8MErRw2gy07LU8/DLeW4/u55vidpKgE/P9a0Y= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Uros Bizjak To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-5785] i386: Wrong code with __builtin_parityl [PR112672] X-Act-Checkin: gcc X-Git-Author: Uros Bizjak X-Git-Refname: refs/heads/master X-Git-Oldrev: 2f3f8952ff1736dd6a087ddb4106077db3502bb9 X-Git-Newrev: b2d17bdd45b582b93e89c00b04763a45f97d7a34 Message-Id: <20231123151826.69C94386186C@sourceware.org> Date: Thu, 23 Nov 2023 15:18:26 +0000 (GMT) List-Id: https://gcc.gnu.org/g:b2d17bdd45b582b93e89c00b04763a45f97d7a34 commit r14-5785-gb2d17bdd45b582b93e89c00b04763a45f97d7a34 Author: Uros Bizjak Date: Thu Nov 23 16:17:57 2023 +0100 i386: Wrong code with __builtin_parityl [PR112672] gen_parityhi2_cmp instruction clobbers its input operand, so use a temporary register in the call to gen_parityhi2_cmp. PR target/112672 gcc/ChangeLog: * config/i386/i386.md (parityhi2): Use temporary register in the call to gen_parityhi2_cmp. gcc/testsuite/ChangeLog: * gcc.target/i386/pr112672.c: New test. Diff: --- gcc/config/i386/i386.md | 4 +++- gcc/testsuite/gcc.target/i386/pr112672.c | 23 +++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 99bb909b244..41de9537a40 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -20031,8 +20031,10 @@ "! TARGET_POPCNT" { rtx scratch = gen_reg_rtx (QImode); + rtx tmp = gen_reg_rtx (HImode); - emit_insn (gen_parityhi2_cmp (operands[1])); + emit_move_insn (tmp, operands[1]); + emit_insn (gen_parityhi2_cmp (tmp)); ix86_expand_setcc (scratch, ORDERED, gen_rtx_REG (CCmode, FLAGS_REG), const0_rtx); diff --git a/gcc/testsuite/gcc.target/i386/pr112672.c b/gcc/testsuite/gcc.target/i386/pr112672.c new file mode 100644 index 00000000000..583e9fdfb8b --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr112672.c @@ -0,0 +1,23 @@ +/* PR target/112672 */ +/* { dg-do run } */ +/* { dg-options "-O2" } */ + +typedef unsigned short u16; + +u16 g = 254; + +static inline u16 +foo (u16 u) +{ + u *= g; + return u + __builtin_parityl (u); +} + +int +main (void) +{ + u16 x = foo (4); + if (x != 4 * 254 + 1) + __builtin_abort (); + return 0; +}